From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] gstreamer: make pulseaudio support dependent on DISTRO_FEATURES
Date: Wed, 26 Sep 2012 14:24:07 +0100 [thread overview]
Message-ID: <1985929.Ib8AKayW0V@helios> (raw)
In-Reply-To: <20120926123257.GK3313@jama.jama.net>
On Wednesday 26 September 2012 14:32:57 Martin Jansa wrote:
> On Wed, Sep 26, 2012 at 01:31:10PM +0100, Paul Eggleton wrote:
> > On Wednesday 26 September 2012 13:38:19 Martin Jansa wrote:
> > > On Wed, Sep 26, 2012 at 12:34:05PM +0100, Paul Eggleton wrote:
> > > > This should be no change to the previous situation unless you
> > > > explicitly have pulseaudio in DISTRO_FEATURES_BACKFILL_CONSIDERED
> > > > (currently).
> > >
> > > Why not use PACKAGECONFIG for this?
> >
> > Only because I didn't see the need complicate it just to be able to
> > configure it on a per-recipe basis - you almost certainly want pulseaudio
> > either on or off everywhere. If you want it for stylistic reasons, sure,
> > I guess... it is a bit ugly though.
>
> Well it looked to me like ideal use-case for PACKAGECONFIG.
It does encapsulate the DEPENDS and EXTRA_OECONF into one piece, yes, but then
when you make the PACKAGECONFIG option set from DISTRO_FEATURES anyway it gets
ugly, and here I'm not convinced it adds anything useful.
FWIW, this also matches how the same configuration is implemented for Qt. If we
want to switch everything over to PACKAGECONFIG later we can with no penalty.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-09-26 13:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 11:34 [PATCH] gstreamer: make pulseaudio support dependent on DISTRO_FEATURES Paul Eggleton
2012-09-26 11:38 ` Martin Jansa
2012-09-26 12:31 ` Paul Eggleton
2012-09-26 12:32 ` Martin Jansa
2012-09-26 13:24 ` Paul Eggleton [this message]
2012-09-26 13:30 ` Martin Jansa
2012-09-26 13:45 ` Paul Eggleton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1985929.Ib8AKayW0V@helios \
--to=paul.eggleton@linux.intel.com \
--cc=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox