Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Julien Stephan <jstephan@baylibre.com>,
	 openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH v3 0/4] devtool/recipetool: add support of PEP-517
Date: Wed, 25 Oct 2023 15:11:07 +0100	[thread overview]
Message-ID: <19b88e474d716513f4ed23327f1eb6004241d7ee.camel@linuxfoundation.org> (raw)
In-Reply-To: <20231024144022.1532605-1-jstephan@baylibre.com>

On Tue, 2023-10-24 at 16:40 +0200, Julien Stephan wrote:
> Hello all,
> 
> This series adds basic support for PEP-517 in recipetool/devtool, plus somes
> others fixes.
> 
> Recipetool/devtool selftest passed locally
> 
> Missing features:
> - extra or optionnal dependencies are not handled
> - version number for dependencies are not handled (issue already present
>   for the legacy setuptool)
> - some projects can declare a minimal pyproject.toml file, and put all
>   the metadata in setup.py/setup.cfg/requirements.txt .. theses cases
>   are not handled. If a pyproject.toml file is found, assumes it has all
>   necessary metadata.
> 
> Changes from v2:
> - try to use tomllib from python core (since 3.11) and if not available,
>   try to import tomli (instead of toml, as tomllib and tomli have both the
>   same api)
> - improve support for poetry: poetry looks for metadata into the
>   "tools.poetry" section instead of the "project" section
> - add the selftests for the 3 supported backends. Skip the tests if
>   tomliib (python > 3.11) or tomli is not installed
> - fix self test failing with the new "python3-" prefix added to
>   recipetool for python recipes

This patch series still doesn't seem to apply against master. Could you
check your rebase is ok or if there is a patch missing or something?

Cheers,

Richard


  parent reply	other threads:[~2023-10-25 14:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-24 14:40 [PATCH v3 0/4] devtool/recipetool: add support of PEP-517 Julien Stephan
2023-10-24 14:40 ` [PATCH v3 1/4] scripts:recipetool:create_buildsys_python: prefix created recipes with python3- Julien Stephan
2023-10-24 14:40 ` [PATCH v3 2/4] scripts:recipetool:create_buildsys_python: refactor code for futur PEP517 addition Julien Stephan
2023-10-24 14:40 ` [PATCH v3 3/4] scripts:recipetool:create_buildsys_python: add PEP517 support Julien Stephan
2023-10-24 14:40 ` [PATCH v3 4/4] oeqa/selftest/recipetool: add selftest for PEP-517 recipe creation Julien Stephan
2023-10-25 14:11 ` Richard Purdie [this message]
2023-10-25 15:48   ` [OE-core] [PATCH v3 0/4] devtool/recipetool: add support of PEP-517 Julien Stephan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19b88e474d716513f4ed23327f1eb6004241d7ee.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=jstephan@baylibre.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox