Re: [OE-core] [PATCH] initramfs-framework: remove hard dependency with busybox

[Adrian Freihofer <adrian.freihofer@gmail.com>]

Hi Christos

Since the -c has been around for a very long time, I assume that there
are many users who use it with busybox. Using it with core-utils will
probably remain the special use case.
The proposed fix raises the question of why the -c was introduced at
some point. If your fix also works for busybox, was the -c always
redundant? Or has something changed in the meantime?

Please also address the busybox users' point of view in the commit
message and summarize how this was tested with busybox in particular.

Thank you.
Adrian


On Fri, 2025-03-28 at 19:04 +0100, Christos Gavros via
lists.openembedded.org wrote:
> In 'finish'script the Switch_root command with option -c is busybox
> specific.
> When package-core-base-utils is selected the boot is breaking.
> Remove -c option to make it compatible with both providers
> Fixes [YOCTO #15716]
> 
> CC: Yoann Congal <yoann.congal@smile.fr>
> CC: Randy MacLeod <randy.macleod@windriver.com>
> CC: Ross Burton <ross.burton@arm.com>
> CC: jbk <jbk@mm-software.com>
> Signed-off-by: Christos Gavros <gavrosc@yahoo.com>
> ---
>  meta/recipes-core/initrdscripts/initramfs-framework/finish | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-core/initrdscripts/initramfs-
> framework/finish b/meta/recipes-core/initrdscripts/initramfs-
> framework/finish
> index ac0de9f996..716c2f44af 100755
> --- a/meta/recipes-core/initrdscripts/initramfs-framework/finish
> +++ b/meta/recipes-core/initrdscripts/initramfs-framework/finish
> @@ -41,7 +41,7 @@ finish_run() {
>  		mount --move /sys $ROOTFS_DIR/sys
>  
>  		cd $ROOTFS_DIR
> -		exec switch_root -c /dev/console $ROOTFS_DIR
> ${bootparam_init:-/sbin/init}
> +		exec switch_root $ROOTFS_DIR ${bootparam_init:-
> /sbin/init}
>  	else
>  		debug "No rootfs has been set"
>  	fi
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#213861):
> https://lists.openembedded.org/g/openembedded-core/message/213861
> Mute This Topic: https://lists.openembedded.org/mt/111959232/4454582
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe:
> https://lists.openembedded.org/g/openembedded-core/unsub [
> adrian.freihofer@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>