public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Alexander Kanavin <alex.kanavin@gmail.com>,
	Chi Xu <chi.xu@eng.windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] xz: Add ptest support
Date: Wed, 24 Jan 2024 09:47:02 +0000	[thread overview]
Message-ID: <1a57c97a7219e918a43696080ebabcfecfed26de.camel@linuxfoundation.org> (raw)
In-Reply-To: <CANNYZj-XFMk+Zburj-Q2xLk04BWg=qv8Kk0+=XAOwDdKpjpkQQ@mail.gmail.com>

On Wed, 2024-01-24 at 10:41 +0100, Alexander Kanavin wrote:
> On Wed, 24 Jan 2024 at 10:04, Chi Xu <chi.xu@eng.windriver.com> wrote:
> > +Subject: [PATCH] Update test scripts: replace ../src/* with /usr/bin
> > +
> > +In order to run scripts on target, replace ../src/* with /usr/bin
> > +
> > +Upstream-Status: Inappropriate [embedded specific]
> > +-if test -x ../src/xz/xz ; then
> > ++if test -x /usr/bin/xz ; then
> 
> It's better to bundle the xz* executables into the ptest package where
> the script expects them, and avoid making a non-upstreamable patch
> altogether.

I'd put links in place there to redirect to binares, that way we test
the actual binaries and don't have copies.

Cheers,

Richard


  reply	other threads:[~2024-01-24  9:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-24  9:04 [PATCH] xz: Add ptest support Xu, Chi
2024-01-24  9:41 ` [OE-core] " Alexander Kanavin
2024-01-24  9:47   ` Richard Purdie [this message]
2024-01-25  1:04     ` Xu, Chi
2024-01-25  2:54   ` Xu, Chi
2024-01-25  9:25     ` Alexander Kanavin
  -- strict thread matches above, loose matches on Subject: below --
2024-01-23  8:09 Xu, Chi
2024-01-23  9:43 ` [OE-core] " Alexander Kanavin
2024-01-24  1:38   ` Xu, Chi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a57c97a7219e918a43696080ebabcfecfed26de.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=alex.kanavin@gmail.com \
    --cc=chi.xu@eng.windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox