From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Khem Raj <raj.khem@gmail.com>, openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH v3] rust: Use libc++ runtime when using clang with llvm runtime
Date: Mon, 12 Sep 2022 08:32:44 +0100 [thread overview]
Message-ID: <1af72bce2477a28ef6a75fe23d813e2aee3e4593.camel@linuxfoundation.org> (raw)
In-Reply-To: <20220911232844.680121-1-raj.khem@gmail.com>
On Sun, 2022-09-11 at 16:28 -0700, Khem Raj wrote:
> meta-clang has options when it comes to C++ runtime, default is to use
> gnu runtime, other options are llvm runtime and android runtime. This
> patch helps when a distro is using llvm runtime for C/C++ runtime. It
> informs the rust build system about right C++ runtime to configure for
> when such a setting is used.
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> v2: Rebase now that 1.63 is in
> v3: Use renamed variable RUNTIME -> TC_CXX_RUNTIME
>
> meta/recipes-devtools/rust/rust.inc | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-devtools/rust/rust.inc b/meta/recipes-devtools/rust/rust.inc
> index a33eb00e25..4e78b5ea6f 100644
> --- a/meta/recipes-devtools/rust/rust.inc
> +++ b/meta/recipes-devtools/rust/rust.inc
> @@ -110,6 +110,8 @@ python do_configure() {
> # [llvm]
> config.add_section("llvm")
> config.set("llvm", "static-libstdcpp", e(False))
> + if "llvm" in (d.getVar('TC_CXX_RUNTIME', True) or ""):
> + config.set("llvm", "use-libcxx", e(True))
>
> # [rust]
> config.add_section("rust")
We can drop the True from the getVar as expansion is the default.
Cheers,
Richard
prev parent reply other threads:[~2022-09-12 7:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-11 23:28 [PATCH v3] rust: Use libc++ runtime when using clang with llvm runtime Khem Raj
2022-09-12 7:32 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1af72bce2477a28ef6a75fe23d813e2aee3e4593.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox