Re: [PATCH 1/1] busybox: move init related configs to init.cfg

[ChenQi <Qi.Chen@windriver.com>]

ping

On 07/30/2018 05:41 PM, Chen Qi wrote:
> Move init related configs to init.cfg.
>
> These config items do not make much sense unless busybox is selected
> as the init manager. They should belong to init.cfg.
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
>   meta/recipes-core/busybox/busybox/defconfig | 12 ++++++------
>   meta/recipes-core/busybox/busybox/init.cfg  |  7 ++++++-
>   2 files changed, 12 insertions(+), 7 deletions(-)
>
> diff --git a/meta/recipes-core/busybox/busybox/defconfig b/meta/recipes-core/busybox/busybox/defconfig
> index fbb5fd8..59d93c7 100644
> --- a/meta/recipes-core/busybox/busybox/defconfig
> +++ b/meta/recipes-core/busybox/busybox/defconfig
> @@ -468,21 +468,21 @@ CONFIG_FEATURE_XARGS_SUPPORT_REPL_STR=y
>   # CONFIG_BOOTCHARTD is not set
>   # CONFIG_FEATURE_BOOTCHARTD_BLOATED_HEADER is not set
>   # CONFIG_FEATURE_BOOTCHARTD_CONFIG_FILE is not set
> -CONFIG_HALT=y
> -CONFIG_POWEROFF=y
> -CONFIG_REBOOT=y
> +# CONFIG_HALT is not set
> +# CONFIG_POWEROFF is not set
> +# CONFIG_REBOOT is not set
>   # CONFIG_FEATURE_CALL_TELINIT is not set
> -CONFIG_TELINIT_PATH=""
> +# CONFIG_TELINIT_PATH is not set
>   # CONFIG_INIT is not set
>   # CONFIG_LINUXRC is not set
>   # CONFIG_FEATURE_USE_INITTAB is not set
>   # CONFIG_FEATURE_KILL_REMOVED is not set
> -CONFIG_FEATURE_KILL_DELAY=0
> +# CONFIG_FEATURE_KILL_DELAY is not set
>   # CONFIG_FEATURE_INIT_SCTTY is not set
>   # CONFIG_FEATURE_INIT_SYSLOG is not set
>   # CONFIG_FEATURE_INIT_QUIET is not set
>   # CONFIG_FEATURE_INIT_COREDUMPS is not set
> -CONFIG_INIT_TERMINAL_TYPE=""
> +# CONFIG_INIT_TERMINAL_TYPE is not set
>   # CONFIG_FEATURE_INIT_MODIFY_CMDLINE is not set
>   
>   #
> diff --git a/meta/recipes-core/busybox/busybox/init.cfg b/meta/recipes-core/busybox/busybox/init.cfg
> index 006d4c6..3c1fdd4 100644
> --- a/meta/recipes-core/busybox/busybox/init.cfg
> +++ b/meta/recipes-core/busybox/busybox/init.cfg
> @@ -1,3 +1,8 @@
>   CONFIG_INIT=y
>   CONFIG_FEATURE_USE_INITTAB=y
> -
> +CONFIG_HALT=y
> +CONFIG_POWEROFF=y
> +CONFIG_REBOOT=y
> +CONFIG_FEATURE_KILL_DELAY=0
> +CONFIG_TELINIT_PATH=""
> +CONFIG_INIT_TERMINAL_TYPE=""