public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Pedro Silva Ferreira <Pedro.Silva.Ferreira@criticaltechworks.com>,
	 Steve Sakoman <steve@sakoman.com>
Cc: "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH v2 1/2] buildhistory: fix package output folder creation
Date: Tue, 27 Aug 2024 15:10:42 +0100	[thread overview]
Message-ID: <1e6757fe926b7059a5366b3c7e21c380b6400fb8.camel@linuxfoundation.org> (raw)
In-Reply-To: <AM8P193MB09007D00E8018039DD5FC6A1C7942@AM8P193MB0900.EURP193.PROD.OUTLOOK.COM>

On Tue, 2024-08-27 at 12:50 +0000, Pedro Silva Ferreira wrote:
> Hi Steve and Richard,
> 
> I tried to backport locally patches [4] and [5] to kirkstone and
> scarthgap but i ran into some issues related to sstate.bbclass. After
> some investigation i saw that i was missing a patch done by Richard
> [3] in the context of this buildhistory change but after applying the
> patch [3], due to the `interceptfuncs` logic i ran into an undefined
> variable (SSTATE_INSTDIR) while executing `bb.utils.rename` helper
> function. Applying patch [1] and [2] in combination with [3] , [4]
> and [5] seems to do the job but im not really sure if patch [1] and
> [2] can be backported to lts branches since they remove some
> features/class that might be used by other components that I am not
> aware of. I tested this with ncurses recipe and with core-image-
> minimal.
> 
> 1: siteconfig: Drop siteconfig class/code/support
> f3766dc038f7ba9780ddaf5eb8d27385ea31d7d0
> 2: sstate: Drop intercept functions support
> cfbfd0b2e89eb71783c55a1be4a7e63e6cd82c2f

We definitely can't backport those.

> 3: sstate/buildhistory: Fix plaindirs handling to occur before
> SSTATEPOSTINSTFUNCS
> 62ee349cf18532dac8736488752c00e89de78fcd

We'd probably need to find a way to make that change and continue to
work with the intercept functions :/.

Cheers,

Richard


  reply	other threads:[~2024-08-27 14:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-06 12:59 [PATCH v2 1/2] buildhistory: fix package output folder creation Pedro Ferreira
2024-08-06 12:59 ` [PATCH v2 2/2] buildhistory: Restoring files from preserve list Pedro Ferreira
2024-08-07 15:55 ` [OE-core] [PATCH v2 1/2] buildhistory: fix package output folder creation Alexandre Belloni
2024-08-07 16:44   ` Richard Purdie
2024-08-08 12:19     ` Peter Kjellerstedt
2024-08-13  8:05     ` Pedro Ferreira
2024-08-13 12:09       ` [OE-core] " Steve Sakoman
2024-08-27 12:50         ` Pedro Silva Ferreira
2024-08-27 14:10           ` Richard Purdie [this message]
2024-08-29 10:55             ` Pedro Silva Ferreira
2024-08-29 11:53               ` Richard Purdie
2024-08-29 12:00               ` Richard Purdie
2024-08-29 14:21                 ` Pedro Silva Ferreira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e6757fe926b7059a5366b3c7e21c380b6400fb8.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=Pedro.Silva.Ferreira@criticaltechworks.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=steve@sakoman.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox