Qt4 mips-relocate.patch

Qt4 mips-relocate.patch

[Paul Eggleton]

Hi there,

I was going through patches for Qt4 and found that (among others) mips-
relocate.patch was not being applied for Qt 4.7.x. From the comment it seems 
it was intended to fix a link-time error when building qt4-x11-free for mips - 
some kind of issue with binutils 2.20 [1]. However I just built qt4-x11-free 
4.7.3 with MACHINE=qemumips without the patch and it built just fine. We're 
using binutils 2.21 now, I checked and there is nothing relevant that I can 
see in the binutils changelog to suggest that a mips/symbolic-functions issue 
was fixed, and we are apparently still enabling the option that originally 
triggered the problem when building Qt 4.7.x.

Ke / anyone else, any ideas? If the problem can no longer reproduced can we 
simply remove this patch?

Cheers,
Paul

[1] http://bugzilla.pokylinux.org/show_bug.cgi?id=271

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: Qt4 mips-relocate.patch

[Yu, Ke]

Hi Paul,

This patch is to fix the issue which is specifically found in Qt4.6.x with binutils 2.20.  and the upgrade of either Qt or binutils may fix this issue. Since you have go through the binutils change, and did not find relevant commit, probably the relevant change lies in Qt upgrade, or more specifically, the change with libQtWebKit. 

Regardless of where the root cause may be, since the combination of QT4.7 and bintuils 2.21 can pass the build now, I think it is safe to remove this patch and reenable the "-Bsymbolic-functions" flag. It is will also benefit the runtime performance.

Regards
Ke

-----Original Message-----
From: Paul Eggleton [mailto:paul.eggleton@linux.intel.com] 
Sent: Wednesday, May 18, 2011 12:13 AM
To: Yu, Ke
Cc: openembedded-core@lists.openembedded.org
Subject: Qt4 mips-relocate.patch

Hi there,

I was going through patches for Qt4 and found that (among others) mips- relocate.patch was not being applied for Qt 4.7.x. From the comment it seems it was intended to fix a link-time error when building qt4-x11-free for mips - some kind of issue with binutils 2.20 [1]. However I just built qt4-x11-free
4.7.3 with MACHINE=qemumips without the patch and it built just fine. We're using binutils 2.21 now, I checked and there is nothing relevant that I can see in the binutils changelog to suggest that a mips/symbolic-functions issue was fixed, and we are apparently still enabling the option that originally triggered the problem when building Qt 4.7.x.

Ke / anyone else, any ideas? If the problem can no longer reproduced can we simply remove this patch?

Cheers,
Paul

[1] http://bugzilla.pokylinux.org/show_bug.cgi?id=271

-- 

Paul Eggleton
Intel Open Source Technology Centre