From: Martin Jansa <martin.jansa@gmail.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/2] package.bbclass, prserv.bbclass: Compare USE_PR_SERV with "1" or "0"
Date: Sat, 28 May 2011 10:08:34 +0200 [thread overview]
Message-ID: <20110528080834.GS3222@jama.jama.net> (raw)
In-Reply-To: <F46CB9CD-BA76-4A6E-AFD7-2A2833C5743F@dominion.thruhere.net>
[-- Attachment #1: Type: text/plain, Size: 2283 bytes --]
On Sat, May 28, 2011 at 09:50:09AM +0200, Koen Kooi wrote:
>
> Op 28 mei 2011, om 04:44 heeft Khem Raj het volgende geschreven:
>
> > Value of USE_PR_SERV is either "1" or "0" looking at
> > settings in bitbake.conf
> > USE_PR_SERV = "${@[1,0][(bb.data.getVar('PRSERV_HOST',d,1) is None) or (bb.data.getVar('PRSERV_PORT',d,1) is None)]}"
> > So we compare the strings
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
>
> Fixes the problem for me:
>
> Tested-by: Koen Kooi <koen@dominion.thruhere.net>
For me too:
Tested-by: Martin Jansa <Martin.Jansa@gmail.com>
> > ---
> > meta/classes/package.bbclass | 2 +-
> > meta/classes/prserv.bbclass | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
> > index a1b9482..1e6a872 100644
> > --- a/meta/classes/package.bbclass
> > +++ b/meta/classes/package.bbclass
> > @@ -330,7 +330,7 @@ def runtime_mapping_rename (varname, d):
> > #
> >
> > python package_get_auto_pr() {
> > - if d.getVar('USE_PR_SERV', True):
> > + if d.getVar('USE_PR_SERV', True) != "0":
> > auto_pr=prserv_get_pr_auto(d)
> > if auto_pr is None:
> > bb.fatal("Can NOT get auto PR revision from remote PR service")
> > diff --git a/meta/classes/prserv.bbclass b/meta/classes/prserv.bbclass
> > index de46ff6..18b8589 100644
> > --- a/meta/classes/prserv.bbclass
> > +++ b/meta/classes/prserv.bbclass
> > @@ -12,7 +12,7 @@ def prserv_make_conn(d):
> > return conn
> >
> > def prserv_get_pr_auto(d):
> > - if not d.getVar('USE_PR_SERV', True):
> > + if d.getVar('USE_PR_SERV', True) != "0":
> > bb.warn("Not using network based PR service")
> > return None
> >
> > --
> > 1.7.4.1
> >
> >
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
next prev parent reply other threads:[~2011-05-28 8:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-28 2:44 [PATCH 0/2] misc fixed to compile uclibc in thumb mode and fix prserv Khem Raj
2011-05-28 2:44 ` [PATCH 1/2] uclibc: Add disabled COMPILE_IN_THUMB_MODE to uClibc.machine for all ARM configurations Khem Raj
2011-05-28 2:44 ` [PATCH 2/2] package.bbclass, prserv.bbclass: Compare USE_PR_SERV with "1" or "0" Khem Raj
2011-05-28 7:50 ` Koen Kooi
2011-05-28 8:08 ` Martin Jansa [this message]
2011-05-29 8:40 ` [PATCH 0/2] misc fixed to compile uclibc in thumb mode and fix prserv Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110528080834.GS3222@jama.jama.net \
--to=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox