Re: [PATCH 2/2] eglibc: migrate configurability from oe

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3563 bytes --]

On Wed, Jun 08, 2011 at 02:35:18PM +0800, Kang Kai wrote:
> On 2011年06月08日 14:25, Koen Kooi wrote:
> > Op 8 jun 2011, om 03:45 heeft Kang Kai het volgende geschreven:
> >
> >> On 2011年06月07日 17:48, Koen Kooi wrote:
> >>> Op 7 jun 2011, om 11:42 heeft Kang Kai het volgende geschreven:
> >>>
> >>>> From: Kang Kai<kai.kang@windriver.com>
> >>>>
> >>>> Migrate configurability from oe, try to shrink minimal image size
> >>>>
> >>>> Update to get eglibc configuration options from DISTRO_FEATURES and enable them. All
> >>>> the options are enabled by default.
> >>>>
> >>>> Uncomment the line in conf/local.extended.conf to define DISTRO_FEATURES, so put
> >>>> what options you want to enable there.
> >>>>
> >>>> Signed-off-by: Kang Kai<kai.kang@windriver.com>
> >>>> ---
> >>>> meta/conf/distro/include/default-distrovars.inc    |    8 ++-
> >>>> .../eglibc-2.13-fix-macro-RTLD_DEBUG.patch         |   20 ++++++
> >>>> meta/recipes-core/eglibc/eglibc-options.inc        |   62 ++++++++++++++++++++
> >>>> meta/recipes-core/eglibc/eglibc.inc                |    6 ++
> >>>> meta/recipes-core/eglibc/eglibc_2.13.bb            |    4 +-
> >>>> 5 files changed, 98 insertions(+), 2 deletions(-)
> >>>> create mode 100644 meta/recipes-core/eglibc/eglibc-2.13/eglibc-2.13-fix-macro-RTLD_DEBUG.patch
> >>>> create mode 100644 meta/recipes-core/eglibc/eglibc-options.inc
> >>>>
> >>>> diff --git a/meta/conf/distro/include/default-distrovars.inc b/meta/conf/distro/include/default-distrovars.inc
> >>>> index 4b68a0a..16ac681 100644
> >>>> --- a/meta/conf/distro/include/default-distrovars.inc
> >>>> +++ b/meta/conf/distro/include/default-distrovars.inc
> >>>> @@ -10,7 +10,13 @@ LIMIT_BUILT_LOCALES ?= "POSIX en_US en_GB"
> >>>> ENABLE_BINARY_LOCALE_GENERATION ?= "1"
> >>>> LOCALE_UTF8_ONLY ?= "0"
> >>>>
> >>>> -DISTRO_FEATURES ?= "alsa bluetooth ext2 irda pcmcia usbgadget usbhost wifi nfs zeroconf pci"
> >>>> +DISTRO_FEATURES ?= "alsa bluetooth ext2 irda pcmcia usbgadget usbhost wifi nfs zeroconf pci \
> >>>> +		libc-ipv6 libc-backtrace libc-big-macros libc-bsd libc-cxx-tests libc-catgets libc-charsets libc-crypt \
> >>>> +		libc-crypt-ufc libc-db-aliases libc-envz libc-fcvt libc-fmtmsg libc-fstab libc-ftraverse \
> >>>> +		libc-getlogin libc-idn libc-inet libc-inet-anl libc-libm libc-libm-big libc-locales libc-locale-code \
> >>>> +		libc-memusage libc-nis libc-nsswitch libc-rcmd libc-rtld-debug libc-spawn libc-streams libc-sunrpc \
> >>>> +		libc-utmp libc-utmpx libc-wordexp libc-posix-clang-wchar libc-posix-regexp libc-posix-regexp-glibc \
> >>>> +		libc-posix-wchar-io"
> >> Hi Koen,
> >>> I think a seperate DISTRO_LIBC_FEATURES var would be cleaner and easier to override.
> >> I used DISTRO_FEATURES_EGLIBC before, but it didn't make Richard happy. :)
> > So how does one easily override LIBC features without touching other features?
> That is why use libc-spawn not "spawn" itself.

I agree with koen, when distro wants to keep all default libc-* but
alter other DISTRO_FEATURES it has to list all libc-* in it's own
config.

IMHO DISTRO_FEATURES_EGLIBC had wrong only suffix as it's not _EGLIBC
specific,

DISTRO_FEATURES_LIBC or proposed DISTRO_LIBC_FEATURES will allow
distributions to override it like this:
DISTRO_FEATURES = "foo bar ${DISTRO_FEATURES_LIBC}" which is much better
then 6 lines of libc-* features which need to resync when someone adds
new feature with new *libc version.

Regards,

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Type: application/pgp-signature, Size: 205 bytes --]