From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga14.intel.com ([143.182.124.37])
	by linuxtogo.org with esmtp (Exim 4.72)
	(envelope-from <paul.eggleton@linux.intel.com>) id 1QYdow-0001NS-NQ
	for openembedded-core@lists.openembedded.org;
	Mon, 20 Jun 2011 14:43:14 +0200
Received: from azsmga001.ch.intel.com ([10.2.17.19])
	by azsmga102.ch.intel.com with ESMTP; 20 Jun 2011 05:39:41 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="4.65,394,1304319600"; d="scan'208";a="15544300"
Received: from unknown (HELO helios.localnet) ([10.255.16.236])
	by azsmga001.ch.intel.com with ESMTP; 20 Jun 2011 05:39:38 -0700
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Date: Mon, 20 Jun 2011 13:39:37 +0100
User-Agent: KMail/1.13.6 (Linux/2.6.38-8-generic-pae; KDE/4.6.2; i686; ; )
References: <cover.1308543589.git.dexuan.cui@intel.com>
	<2152759b50cc3acc96ee57b242e0b896e65f5e93.1308543589.git.dexuan.cui@intel.com>
In-Reply-To: <2152759b50cc3acc96ee57b242e0b896e65f5e93.1308543589.git.dexuan.cui@intel.com>
MIME-Version: 1.0
Message-Id: <201106201339.37154.paul.eggleton@linux.intel.com>
Subject: Re: [PATCH 1/1] sanity.bbclass: only run check_pseudo_wrapper for bitbake
X-BeenThere: openembedded-core@lists.openembedded.org
X-Mailman-Version: 2.1.11
Precedence: list
Reply-To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
List-Id: Patches and discussions about the oe-core layer
	<openembedded-core.lists.openembedded.org>
List-Unsubscribe: <http://lists.linuxtogo.org/cgi-bin/mailman/options/openembedded-core>,
	<mailto:openembedded-core-request@lists.openembedded.org?subject=unsubscribe>
List-Archive: <http://lists.linuxtogo.org/pipermail/openembedded-core>
List-Post: <mailto:openembedded-core@lists.openembedded.org>
List-Help: <mailto:openembedded-core-request@lists.openembedded.org?subject=help>
List-Subscribe: <http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core>,
	<mailto:openembedded-core-request@lists.openembedded.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Jun 2011 12:43:15 -0000
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit

On Monday 20 June 2011 05:25:03 Dexuan Cui wrote:
> This patch eliminates the warning "not been run using the bitbake
> wrapper..." when we run bitbake-layers.
> 
> Thanks Paul Eggleton for suggesting doing this in sanity.bbclass.
> 
> Signed-off-by: Dexuan Cui <dexuan.cui@intel.com>
> ---
>  meta/classes/sanity.bbclass |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index fc005aa..d296c86 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -42,6 +42,10 @@ def check_sanity_version_change():
>      return ""
> 
>  def check_pseudo_wrapper():
> +    import sys
> +    if not sys.argv[0].endswith('/bitbake'):
> +        return ""
> +
>      import subprocess as sub
>      # Check if bitbake wrapper is being used
>      pseudo_build = os.environ.get( 'PSEUDO_BUILD' )

Looks good to me.

Acked-by: Paul Eggleton <paul.eggleton@linux.intel.com>

-- 

Paul Eggleton
Intel Open Source Technology Centre