From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from stoexhub01.domain01.net ([83.145.59.142]
	helo=stoexhub02.domain01.net) by linuxtogo.org with esmtp (Exim 4.72)
	(envelope-from <anders@chargestorm.se>) id 1Qe5CH-0004nB-6V
	for openembedded-core@lists.openembedded.org;
	Tue, 05 Jul 2011 14:57:49 +0200
Received: from localhost (193.235.91.228) by stoexhub02.domain01.net
	(10.12.10.2) with Microsoft SMTP Server id 8.3.137.0; Tue, 5 Jul 2011
	14:53:59 +0200
From: Anders Darander <anders@chargestorm.se>
Organization: ChargeStorm AB
To: <openembedded-core@lists.openembedded.org>
Date: Tue, 5 Jul 2011 14:54:04 +0200
User-Agent: KMail/1.13.7 (Linux/2.6.39-2-amd64; KDE/4.6.4; x86_64; ; )
References: <cover.1309867242.git.anders@chargestorm.se>
	<406427a001cfa7c1859f54147b678f0ef647a922.1309867242.git.anders@chargestorm.se>
	<1309869846.2410.3.camel@phil-desktop>
In-Reply-To: <1309869846.2410.3.camel@phil-desktop>
MIME-Version: 1.0
Message-ID: <201107051454.04409.anders@chargestorm.se>
X-GFI-SMTP-Submission: 1
Subject: Re: [PATCH 1/1] kernel.bbclass: make external module compile
X-BeenThere: openembedded-core@lists.openembedded.org
X-Mailman-Version: 2.1.11
Precedence: list
Reply-To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
List-Id: Patches and discussions about the oe-core layer
	<openembedded-core.lists.openembedded.org>
List-Unsubscribe: <http://lists.linuxtogo.org/cgi-bin/mailman/options/openembedded-core>,
	<mailto:openembedded-core-request@lists.openembedded.org?subject=unsubscribe>
List-Archive: <http://lists.linuxtogo.org/pipermail/openembedded-core>
List-Post: <mailto:openembedded-core@lists.openembedded.org>
List-Help: <mailto:openembedded-core-request@lists.openembedded.org?subject=help>
List-Subscribe: <http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core>,
	<mailto:openembedded-core-request@lists.openembedded.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Jul 2011 12:57:49 -0000
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit


* Phil Blundell Phil Blundell <pb@pbcl.net> [07/05/11 02:44 PM]:
> On Tue, 2011-07-05 at 14:01 +0200, Anders Darander wrote:
> > diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> > index 943252a..26ee416 100644
> > --- a/meta/classes/kernel.bbclass
> > +++ b/meta/classes/kernel.bbclass
> > @@ -149,7 +149,6 @@ kernel_do_install() {
> 
>         #
>         # We don't want to leave host-arch binaries in /sysroots, so
>         # we clean the scripts dir while leaving the generated config
> 
> >  	# and include files.
> >  	#
> >  	oe_runmake -C $kerneldir CC="${KERNEL_CC}" LD="${KERNEL_LD}" clean
> > 
> > -	make -C $kerneldir _mrproper_scripts
> > 
> >  	find $kerneldir -path $kerneldir/scripts -prune -o -name "*.[csS]"
> >  	-exec rm '{}' \; find $kerneldir/Documentation -name "*.txt" -exec rm
> >  	'{}' \;
> 
> Did you verify that this doesn't introduce any new QA warnings during
> packaging?  Presumably that line was originally added for a reason and
> it seems a bit surprising that just deleting it without any replacement
> is the right thing to do.

No, I didn't really verify that. Do I need to run with any specific options 
enabled, or should it be enough to just bitbake my modules recipe? (I can't 
test for the moment, as the latest pull from oe-core forces a rebuild of gcc 
etc).
 
> Also, if the scripts dir isn't being cleaned anymore, I guess the
> preceding comment should be adjusted to match the new reality.

That's true.

I'll wait to see if someone else has any comments, or if I find some QA 
warnings before I produce a version 2.

Regards,
Anders