From: Anders Darander <anders@chargestorm.se>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 4/5] ofono: conditionally enable bluetooth
Date: Wed, 17 Aug 2011 08:31:23 +0200 [thread overview]
Message-ID: <20110817063123.GE7904@chargestorm.se> (raw)
In-Reply-To: <5AA93A51-0AF1-4B3E-8B9A-7E1A1A8C2C18@dominion.thruhere.net>
* Koen Kooi <koen@dominion.thruhere.net> [110816 16:34]:
> Op 16 aug. 2011, om 15:57 heeft Anders Darander het volgende geschreven:
> > Use DISTRO_FEATURE to conditionally depend on bluez4, as well as enabling bluetooth.
> >
> > Signed-off-by: Anders Darander <anders@chargestorm.se>
> > ---
> > meta/recipes-connectivity/ofono/ofono.inc | 3 ++-
> > meta/recipes-connectivity/ofono/ofono_0.50.bb | 1 +
> > meta/recipes-connectivity/ofono/ofono_git.bb | 4 ++++
> > 3 files changed, 7 insertions(+), 1 deletions(-)
> >
> > diff --git a/meta/recipes-connectivity/ofono/ofono.inc b/meta/recipes-connectivity/ofono/ofono.inc
> > index a14b35a..ab233dc 100644
> > --- a/meta/recipes-connectivity/ofono/ofono.inc
> > +++ b/meta/recipes-connectivity/ofono/ofono.inc
> > @@ -7,7 +7,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=eb723b61539feef013de476e68b5c50a \
> >
> > inherit autotools pkgconfig update-rc.d
> >
> > -DEPENDS = "dbus glib-2.0 udev bluez4"
> > +BLUEZDEPENDS = "bluez4"
> > +DEPENDS = "dbus glib-2.0 udev ${@base_contains('DISTRO_FEATURES', 'bluetooth','${BLUEZDEPENDS}', '', d)}"
> is that BLUEZDEPENDS helper var really needed?
I'll rework this patch and send an updated pull-request shortly.
Cheers,
Anders
--
Anders Darander
ChargeStorm AB
next prev parent reply other threads:[~2011-08-17 6:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-16 13:57 [PATCH 0/5] Miscellaneous fixes: mainly qt- and DISTRO_FEATURES-related Anders Darander
2011-08-16 13:57 ` [PATCH 1/5] qt4: allow a reduction in build time Anders Darander
2011-08-16 14:18 ` Paul Eggleton
2011-08-17 14:08 ` Richard Purdie
2011-08-17 17:15 ` Anders Darander
2011-08-17 17:51 ` Anders Darander
2011-08-16 13:57 ` [PATCH 2/5] qmake_base: add uclibceabi Anders Darander
2011-08-16 13:57 ` [PATCH 3/5] connman: use DISTRO_FEATURES to enable wifi and bluetooth Anders Darander
2011-08-16 13:57 ` [PATCH 4/5] ofono: conditionally enable bluetooth Anders Darander
2011-08-16 14:33 ` Koen Kooi
2011-08-17 6:31 ` Anders Darander [this message]
2011-08-16 13:57 ` [PATCH 5/5] create-pull-request: increase likelihood of detecting a rename Anders Darander
2011-08-23 1:00 ` [PATCH 0/5] Miscellaneous fixes: mainly qt- and DISTRO_FEATURES-related Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110817063123.GE7904@chargestorm.se \
--to=anders@chargestorm.se \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox