From: Martin Jansa <martin.jansa@gmail.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] atk: add patch to replace G_CONST_RETURN with const
Date: Fri, 30 Sep 2011 20:26:41 +0200 [thread overview]
Message-ID: <20110930182641.GG7364@jama.jama.net> (raw)
In-Reply-To: <20110930174330.GF7364@jama.jama.net>
[-- Attachment #1: Type: text/plain, Size: 1912 bytes --]
On Fri, Sep 30, 2011 at 07:43:30PM +0200, Martin Jansa wrote:
> On Fri, Sep 30, 2011 at 10:33:18AM -0700, Saul Wold wrote:
> > On 09/30/2011 01:47 AM, Martin Jansa wrote:
> > > * otherwise build fails when glib is 2.30.0 or newer (and G_DISABLE_DEPRECATED is enabled - like in atk)
> > >
> > > Signed-off-by: Martin Jansa<Martin.Jansa@gmail.com>
> > > ---
> > > .../atk/atk-1.32.0/remove.G_CONST_RETURN.patch | 628 ++++++++++++++++++++
> > > meta/recipes-support/atk/atk_1.32.0.bb | 5 +-
> > > 2 files changed, 632 insertions(+), 1 deletions(-)
> > > create mode 100644 meta/recipes-support/atk/atk-1.32.0/remove.G_CONST_RETURN.patch
> > >
> > > diff --git a/meta/recipes-support/atk/atk-1.32.0/remove.G_CONST_RETURN.patch b/meta/recipes-support/atk/atk-1.32.0/remove.G_CONST_RETURN.patch
> > > new file mode 100644
> > > index 0000000..0cdf041
> > > --- /dev/null
> > > +++ b/meta/recipes-support/atk/atk-1.32.0/remove.G_CONST_RETURN.patch
> > > @@ -0,0 +1,628 @@
> > > +Upstream-Status: Accepted
> > > +
> > > +Similar patch is already included in 2.0.1 and newer
> > > +http://ftp.gnome.org/pub/gnome/sources/atk/2.0/atk-2.0.1.news
> > > +
> >
> > No Signed-off-by: in the patch header.
> >
> > If the newer version of atk is available, why not update atk in oe-core
> > to that version and not add this patch?
> >
> > Is there a reason we can't update to 2.0.1 at this time?
>
> I'm not atk expert so to minimize influence of such build fix I didn't
> want to upgrade to new major version. But if the 2.0 API is compatible
> feel free to update to 2.0.1.
>
> Btw: I've included this patch to "Glib related change" pull request
> later when I had more changes to send them as separate patches..
I've updated this patch in jansa/glib with SOB line and sent PATCHv2 to
ml.
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
prev parent reply other threads:[~2011-09-30 18:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 8:47 [PATCH] atk: add patch to replace G_CONST_RETURN with const Martin Jansa
2011-09-30 17:33 ` Saul Wold
2011-09-30 17:43 ` Martin Jansa
2011-09-30 18:26 ` Martin Jansa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110930182641.GG7364@jama.jama.net \
--to=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox