Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [RFC] bitbake.conf: include only ${libdir}/${BPN}/*${SOLIBS} not whole ${libdir}/${BPN}/* in FILES_${PN}-dev
Date: Tue, 18 Oct 2011 13:54:25 +0200	[thread overview]
Message-ID: <20111018115425.GD20678@jama.jama.net> (raw)
In-Reply-To: <1318860385.22985.118.camel@phil-desktop>

[-- Attachment #1: Type: text/plain, Size: 2178 bytes --]

On Mon, Oct 17, 2011 at 03:06:24PM +0100, Phil Blundell wrote:
> On Mon, 2011-10-17 at 15:59 +0200, Martin Jansa wrote:
> > On Mon, Oct 17, 2011 at 02:48:29PM +0100, Phil Blundell wrote:
> > > If there are .la or .so files in ${libdir}/${PN} that are causing a
> > > problem then it does seem reasonable to add them to FILES_${PN}-dev.
> > > But I don't think that restricting the scope of FILES_${PN} is
> > > desirable, or ought to be necessary.
> > 
> > How to do this with this order of PACKAGES, without redefining PACKAGES
> > itself?
> > 
> > PACKAGES = "${PN}-dbg ${PN} ${PN}-doc ${PN}-dev ${PN}-staticdev ${PN}-locale"
> 
> Ah, hm.  I had thought for some reason that ${PN}-dev was before ${PN}
> but evidently that's not correct.  So you're right, there is probably no
> good way to do it without fiddling FILES_${PN}.  
> 
> That being the case, I am inclined to say that this ought just to be
> fixed locally in the recipes that have the problem: it isn't very
> obvious to me that setting a restrictive glob on FILES_${PN} (and then
> having to edit all the recipes that install non-library things in there)
> is going to be a net win compared to just fixing the recipes that are
> currently shipping .la files in there by mistake.

OK, I didn't any research to find what type of files are usually stored
in ${libdir}/${BPN} but find /usr/lib64 on my gentoo box suggests that
you're right (almost every directory under /usr/lib64 has something more
than .so and .la files:

# find /usr/lib64/ -mindepth 1 -maxdepth 1 -type d | wc -l 
186
# for i in `find /usr/lib64/ -mindepth 1 -maxdepth 1 -type d`; do ls -1 $i/* 2>/dev/null | grep -v ".so" | wc -l | grep -v '^0$'; done | wc -l
136
# for i in `find /usr/lib64/ -mindepth 1 -maxdepth 1 -type d`; do ls -1 $i/* 2>/dev/null | grep -v ".so" | grep -v ".la" | wc -l | grep -v '^0$'; done | wc -l
128

I've fixed it in syslog-ng by redifining FILES_${PN} in
http://git.openembedded.org/meta-openembedded/commit/?id=1ab4e30380da2444cfc66fe5283beb83168964a7

and we can ignore this conf/bitbake.conf patch.

Thanks

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

      reply	other threads:[~2011-10-18 12:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-17 12:52 [RFC] bitbake.conf: include only ${libdir}/${BPN}/*${SOLIBS} not whole ${libdir}/${BPN}/* in FILES_${PN}-dev Martin Jansa
2011-10-17 12:55 ` Otavio Salvador
2011-10-17 13:48 ` Phil Blundell
2011-10-17 13:59   ` Martin Jansa
2011-10-17 14:06     ` Phil Blundell
2011-10-18 11:54       ` Martin Jansa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111018115425.GD20678@jama.jama.net \
    --to=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox