Re: [PATCH 3/8] pulseaudio-0.9.23: force ARM mode

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2122 bytes --]

On Sat, Oct 22, 2011 at 01:33:46PM +0100, Phil Blundell wrote:
> On Fri, 2011-10-21 at 18:16 +0200, Martin Jansa wrote:
> > On Fri, Oct 21, 2011 at 08:40:20AM -0700, Khem Raj wrote:
> > > On Fri, Oct 21, 2011 at 1:17 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> > > > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > > > ---
> > > >  .../pulseaudio/pulseaudio_0.9.23.bb                |    1 +
> > > >  1 files changed, 1 insertions(+), 0 deletions(-)
> > > >
> > > > diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb b/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb
> > > > index 4ac2418..2f872b8 100644
> > > > --- a/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb
> > > > +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_0.9.23.bb
> > > > @@ -23,3 +23,4 @@ do_compile_prepend() {
> > > >     cp ${STAGING_LIBDIR}/libltdl* ${S}/libltdl
> > > >  }
> > > >
> > > > +ARM_INSTRUCTION_SET = "arm"
> > > 
> > > not averse to patch but it would be nice to know what fails in thumb mode.
> > 
> > selected processor does not support Thumb mode `swp r1,r2,[r3]'
> 
> If it's only that one error (presumably some kind of home-grown atomic
> operation) then let's just fix the code in question rather than forcing
> the whole thing to build in ARM-state.  Or if the code is hard to fix,
> patch the makefile so that only the particular source files with the
> assembly in are built for ARM and let the rest stay as Thumb.  Making
> the whole package be ARM is a bit of a heavyweight fix for that issue.

That's why I've called it work around in cover, because I think that fixing it in
old 0.9.23 is not worth it, we can try to fix it in 1.1 when we have it.

And it's not the only one error, I've updated commit message with bigger
chunk of log in 
http://git.openembedded.org/openembedded-core-contrib/log/?h=jansa/pull

and for om-gta02 (armv4t) it's about
selected processor does not support Thumb mode `mla r3,r7,r0,r3'

while swp was from spitz (armv5te).

Regards,

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]