Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH][oe-core 14/22] libsdl: enable alsa/opengl based on PACKAGECONFIG and respect DISTRO_FEATURES
Date: Wed, 16 Nov 2011 00:45:57 +0100	[thread overview]
Message-ID: <20111115234557.GD3600@jama.jama.net> (raw)
In-Reply-To: <d10d38e320b27bfbbf6d069e820a2b6c013bbbdc.1321028799.git.Martin.Jansa@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2964 bytes --]

On Fri, Nov 11, 2011 at 05:28:50PM +0100, Martin Jansa wrote:
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  meta/recipes-graphics/libsdl/libsdl_1.2.14.bb |   10 +++++++---
>  1 files changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/recipes-graphics/libsdl/libsdl_1.2.14.bb b/meta/recipes-graphics/libsdl/libsdl_1.2.14.bb
> index 17a3103..2f49f16 100644
> --- a/meta/recipes-graphics/libsdl/libsdl_1.2.14.bb
> +++ b/meta/recipes-graphics/libsdl/libsdl_1.2.14.bb
> @@ -12,7 +12,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=27818cd7fd83877a8e3ef82b82798ef4"
>  
>  PROVIDES = "virtual/libsdl"
>  
> -DEPENDS = "${@base_contains('DISTRO_FEATURES', 'opengl', 'virtual/libgl', '', d)} virtual/libx11 libxext libxrandr libxrender alsa-lib tslib"
> +DEPENDS = "virtual/libx11 libxext libxrandr libxrender tslib"
>  DEPENDS_virtclass-nativesdk = "libx11-nativesdk libxrandr-nativesdk libxrender-nativesdk libxext-nativesdk"

As Saul reported PACKAGECONFIG adds build time depends not only to
DEPENDS but they also ends in DEPENDS_virtclass-nativesdk and nothing
provides virtual/libgl-nativesdk. So I've resend this patch changing
only alsa handling to PACKAGECONFIG and keeping opengl as it was.

Cheers,

>  PR = "r1"
> @@ -29,17 +29,21 @@ SRC_URI[sha256sum] = "5d927e287034cb6bb0ebccfa382cb1d185cb113c8ab5115a0759798642
>  inherit autotools binconfig pkgconfig
>  
>  EXTRA_OECONF = "--disable-static --disable-debug --enable-cdrom --enable-threads --enable-timers --enable-endian \
> -                --enable-file --disable-oss --enable-alsa --disable-esd --disable-arts \
> +                --enable-file --disable-oss --disable-esd --disable-arts \
>                  --disable-diskaudio --disable-nas --disable-esd-shared --disable-esdtest \
>                  --disable-mintaudio --disable-nasm --enable-video-x11 --disable-video-dga \
>                  --disable-video-fbcon --disable-video-directfb --disable-video-ps2gs --disable-video-ps3 \
>                  --disable-video-xbios --disable-video-gem --disable-video-dummy \
>                  --enable-input-events --enable-input-tslib --enable-pthreads \
> -		${@base_contains('DISTRO_FEATURES', 'opengl', '--enable-video-opengl', '--disable-video-opengl', d)} \
>  		--disable-video-svga \
>                  --disable-video-picogui --disable-video-qtopia --enable-dlopen \
>                  --disable-rpath"
>  
> +PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES', 'opengl', 'opengl', '', d)} \
> +                   ${@base_contains('DISTRO_FEATURES', 'alsa', 'alsa', '', d)}"
> +PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib,"
> +PACKAGECONFIG[opengl] = "--enable-video-opengl,--disable-video-opengl,virtual/libgl,"
> +
>  PARALLEL_MAKE = ""
>  
>  EXTRA_AUTORECONF += "--include=acinclude --exclude=autoheader"
> -- 
> 1.7.8.rc1
> 

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

  parent reply	other threads:[~2011-11-15 23:52 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-11 16:28 [PATCH][oe-core 00/22] QT4, thumb, subversion, mesa, libsdl, time, util-linux, kbd changes Martin Jansa
2011-11-11 16:28 ` [PATCH][oe-core 01/22] qt4-x11-free: bring back pkg-config fixups Martin Jansa
2011-11-11 16:28 ` [PATCH][oe-core 02/22] libatomics-ops: force ARM mode Martin Jansa
2011-11-11 16:28 ` [PATCH][oe-core 03/22] pulseaudio-0.9.23: " Martin Jansa
2011-11-11 16:28 ` [PATCH][oe-core 04/22] aspell: " Martin Jansa
2011-11-11 16:28 ` [PATCH][oe-core 05/22] webkit-gtk: force arm mode to work around binutils segfault Martin Jansa
2011-11-11 16:28 ` [PATCH][oe-core 06/22] subversion: add 1.7.0 with native support and negative D_P for now Martin Jansa
2011-11-11 16:28 ` [PATCH][oe-core 07/22] base.bbclass: add subversion-native to DEPENDS if there is svn:// in SRC_URI Martin Jansa
2011-11-11 16:28 ` [PATCH][oe-core 08/22] mesa: package gl/egl/osmesa to separate packages Martin Jansa
2011-11-14  4:25   ` Saul Wold
2011-11-11 16:28 ` [PATCH][oe-core 09/22] mesa-common: install internal GL headers to libgl-dev Martin Jansa
2011-11-11 16:28 ` [PATCH][oe-core 10/22] alsa-lib: add nativesdk BBCLASSEXTEND Martin Jansa
2011-11-12  1:26   ` Saul Wold
2011-11-11 16:28 ` [PATCH][oe-core 11/22] libsdl: drop unused files Martin Jansa
2011-11-11 16:28 ` [PATCH][oe-core 12/22] libsdl: rename files dir to libsdl-1.2.14 for faster lookup Martin Jansa
2011-11-11 16:28 ` [PATCH][oe-core 13/22] libsdl: enable cdrom, alsa and tslib, disable rpath and add few fixes from meta-oe Martin Jansa
2011-11-11 16:28 ` [PATCH][oe-core 14/22] libsdl: enable alsa/opengl based on PACKAGECONFIG and respect DISTRO_FEATURES Martin Jansa
2011-11-15 23:43   ` [PATCHv2] libsdl: enable alsa " Martin Jansa
2011-11-15 23:45   ` Martin Jansa [this message]
2011-11-16 10:12     ` [PATCH][oe-core 14/22] libsdl: enable alsa/opengl " Richard Purdie
2011-11-25  7:51       ` Martin Jansa
2011-11-29  5:34         ` Saul Wold
2011-11-29  6:52           ` Martin Jansa
2011-11-11 16:28 ` [PATCH][oe-core 15/22] libsdl: replace tabs with spaces Martin Jansa
2011-11-11 16:28 ` [PATCH][oe-core 16/22] time: rename files dir to time-1.7 for faster lookup Martin Jansa
2011-11-11 16:28 ` [PATCH][oe-core 17/22] time: drop default S and 2 useless comments Martin Jansa
2011-11-11 16:28 ` [PATCH][oe-core 18/22] time: use u-a for time, conflicts with busybox Martin Jansa
2011-11-11 16:28 ` [PATCH][oe-core 19/22] util-linux: use u-a for flock and blockdev, " Martin Jansa
2011-11-11 16:28 ` [PATCH][oe-core 20/22] util-linux: add missing u-a calls for setsid chrt Martin Jansa
2011-11-11 16:28 ` [PATCH][oe-core 21/22] util-linux: bump PR after u-a changes Martin Jansa
2011-11-11 16:28 ` [PATCH][oe-core 22/22] kbd: use u-a for chvt, deallocvt, fgconssole, openvt, conflicts with busybox Martin Jansa
2011-11-15 12:29 ` [PATCH][oe-core 00/22] QT4, thumb, subversion, mesa, libsdl, time, util-linux, kbd changes Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111115234557.GD3600@jama.jama.net \
    --to=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox