From: Martin Jansa <martin.jansa@gmail.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: Kernel version has extra '+' when kernel is built from git
Date: Mon, 12 Dec 2011 09:58:51 +0100 [thread overview]
Message-ID: <20111212085851.GE3783@jama.jama.net> (raw)
In-Reply-To: <3658FA4C-A757-40C6-B6CC-CB4A925103A4@dominion.thruhere.net>
[-- Attachment #1: Type: text/plain, Size: 2069 bytes --]
On Mon, Dec 12, 2011 at 09:53:47AM +0100, Koen Kooi wrote:
>
> Op 12 dec. 2011, om 09:47 heeft Martin Jansa het volgende geschreven:
>
> > On Mon, Dec 12, 2011 at 08:42:06AM +0000, git@git.openembedded.org wrote:
> >> Module: meta-openembedded.git
> >> Branch: master
> >> Commit: c486dfa4013b37972c1a1e4df8616eb6f49de498
> >> URL: http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=c486dfa4013b37972c1a1e4df8616eb6f49de498
> >>
> >> Author: Koen Kooi <koen@dominion.thruhere.net>
> >> Date: Sun Dec 11 09:46:28 2011 +0100
> >>
> >> kernel bbclass: sync with OE-core
> >>
> >> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> >
> > If you're working on shared linux.inc in meta-oe, could you please
> > integrate this:
> >
> > do_configure_prepend() {
> > #otherwise it gets extra '+' "2.6.37+"
> > #because:
> > #$ scripts/setlocalversion . => +
> > #$ make kernelversion => 2.6.37
> > #$ make kernelrelease => 2.6.37+
> > rm -rf ${S}/.git
> > }
>
> That would break the following:
>
> koen@dominion:/OE/tentacle$ tail conf/local.conf -n15 | head -n4
> ASSUME_PROVIDED += "gitam-native"
> PATCHTOOL_pn-linux-ti33x-psp = "gitam"
> PATCHTOOL_pn-linux = "gitam"
> PATCHTOOL_pn-u-boot = "gitam"
>
>
> > I have to do this in every git recipe as I don't like dirs like
> > /lib/modules/2.6.37+
>
>
> > Maybe it should be fixed on kernel.bbclass level, because linux-yocto
> > suffers the same ie /lib/modules/3.0.12-yocto-standard+
> >
> > Ccing oe-core for that..
>
>
> I had a patch for scripts/setlocalversion that got rid of the '+', but I stopped caring after a while. We could just run sed in kernel.bbclass to fix the script.
Even better than removing .git.
Regards,
>
> regards,
>
> Koen
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
next prev parent reply other threads:[~2011-12-12 9:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20111212084206.608CB10332@opal>
2011-12-12 8:47 ` Kernel version has extra '+' when kernel is built from git Martin Jansa
2011-12-12 8:53 ` Koen Kooi
2011-12-12 8:58 ` Martin Jansa [this message]
2011-12-12 15:30 ` Bruce Ashfield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111212085851.GE3783@jama.jama.net \
--to=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox