From: Martin Jansa <martin.jansa@gmail.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] gcc-cross: Don't reference machine specific variables
Date: Wed, 25 Jan 2012 14:57:02 +0100 [thread overview]
Message-ID: <20120125135702.GC3843@jama.jama.net> (raw)
In-Reply-To: <1327424970.19643.99.camel@ted>
[-- Attachment #1: Type: text/plain, Size: 1968 bytes --]
On Tue, Jan 24, 2012 at 05:09:30PM +0000, Richard Purdie wrote:
> gcc-cross is installed into a package architecture specific directory
> and is not meant to be machine specific. This patch replaces MACHINE_ARCH
> with PACKAGE_ARCH to ensure this is really the case.
>
> This was found by examining sstate checksums.
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Acked-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
> diff --git a/meta/recipes-devtools/gcc/gcc-cross.inc b/meta/recipes-devtools/gcc/gcc-cross.inc
> index 0b31a8c..6acf8c5 100644
> --- a/meta/recipes-devtools/gcc/gcc-cross.inc
> +++ b/meta/recipes-devtools/gcc/gcc-cross.inc
> @@ -87,12 +87,12 @@ then
> exit 1
> fi
> echo "lappend boards_dir [pwd]/../../.." > ${B}/site.exp
> - echo "load_generic_config \"unix\"" > ${B}/${MACHINE_ARCH}.exp
> - echo "set_board_info username \$user" >> ${B}/${MACHINE_ARCH}.exp
> - echo "set_board_info rsh_prog ssh" >> ${B}/${MACHINE_ARCH}.exp
> - echo "set_board_info rcp_prog scp" >> ${B}/${MACHINE_ARCH}.exp
> - echo "set_board_info hostname \$target" >> ${B}/${MACHINE_ARCH}.exp
> - DEJAGNU=${B}/site.exp make -k check RUNTESTFLAGS="--target_board=${MACHINE_ARCH}\$@"
> + echo "load_generic_config \"unix\"" > ${B}/${PACKAGE_ARCH}.exp
> + echo "set_board_info username \$user" >> ${B}/${PACKAGE_ARCH}.exp
> + echo "set_board_info rsh_prog ssh" >> ${B}/${PACKAGE_ARCH}.exp
> + echo "set_board_info rcp_prog scp" >> ${B}/${PACKAGE_ARCH}.exp
> + echo "set_board_info hostname \$target" >> ${B}/${PACKAGE_ARCH}.exp
> + DEJAGNU=${B}/site.exp make -k check RUNTESTFLAGS="--target_board=${PACKAGE_ARCH}\$@"
>
> STOP
>
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
prev parent reply other threads:[~2012-01-25 14:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 17:09 [PATCH] gcc-cross: Don't reference machine specific variables Richard Purdie
2012-01-24 17:11 ` Khem Raj
2012-01-25 13:57 ` Martin Jansa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120125135702.GC3843@jama.jama.net \
--to=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox