From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-core@lists.openembedded.org
Cc: openembedded-commits@lists.openembedded.org
Subject: Re: [oe-commits] Joshua Lock : netbase: remove redundant assignments
Date: Mon, 27 Feb 2012 11:33:06 +0100 [thread overview]
Message-ID: <20120227103306.GG3859@jama.jama.net> (raw)
In-Reply-To: <20120222221309.69BFD10336@opal>
[-- Attachment #1: Type: text/plain, Size: 2097 bytes --]
On Wed, Feb 22, 2012 at 10:13:09PM +0000, git@git.openembedded.org wrote:
> Module: openembedded-core.git
> Branch: master
> Commit: c3d5800d2850a186f91b5a0db642aa5d1c20156b
> URL: http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=c3d5800d2850a186f91b5a0db642aa5d1c20156b
>
> Author: Joshua Lock <josh@linux.intel.com>
> Date: Tue Feb 21 17:46:44 2012 -0800
>
> netbase: remove redundant assignments
>
> There's no need to explicitly set PACKAGE_ARCH = MACHINE_ARCH, base.bbclass
> takes care of setting this value for us based on the interfaces for those
> machines being an OVERRIDE.
do_install () {
...
# Disable network manager on machines that commonly do NFS booting
case "${MACHINE}" in
"qemuarm" | "qemux86" | "qemux86-64" | "qemumips" | "qemuppc" )
This causes do_install hash to depend on MACHINE variable for all MACHINEs,
so making whole recipe MACHINE_ARCH would be more effective then rebuilding
TARGET_ARCH package after every MACHINE switch.
Cheers,
>
> Signed-off-by: Joshua Lock <josh@linux.intel.com>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>
> ---
>
> meta/recipes-core/netbase/netbase_4.47.bb | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/meta/recipes-core/netbase/netbase_4.47.bb b/meta/recipes-core/netbase/netbase_4.47.bb
> index ddfa8ad..3aa4915 100644
> --- a/meta/recipes-core/netbase/netbase_4.47.bb
> +++ b/meta/recipes-core/netbase/netbase_4.47.bb
> @@ -47,7 +47,3 @@ do_install () {
> }
>
> CONFFILES_${PN} = "${sysconfdir}/hosts ${sysconfdir}/network/interfaces"
> -
> -PACKAGE_ARCH_qemuarm = "${MACHINE_ARCH}"
> -PACKAGE_ARCH_qemux86 = "${MACHINE_ARCH}"
> -PACKAGE_ARCH_qemux86-64 = "${MACHINE_ARCH}"
>
>
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-commits
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
next parent reply other threads:[~2012-02-27 10:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120222221309.69BFD10336@opal>
2012-02-27 10:33 ` Martin Jansa [this message]
2012-02-27 11:31 ` [oe-commits] Joshua Lock : netbase: remove redundant assignments Koen Kooi
2012-02-27 12:13 ` Richard Purdie
2012-02-27 12:36 ` Martin Jansa
2012-02-27 12:47 ` Richard Purdie
2012-02-27 13:46 ` Martin Jansa
2012-02-27 13:26 ` Koen Kooi
2012-02-27 13:31 ` Otavio Salvador
2012-02-27 20:19 ` Koen Kooi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120227103306.GG3859@jama.jama.net \
--to=martin.jansa@gmail.com \
--cc=openembedded-commits@lists.openembedded.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox