Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] udev-164: don't hardcode path to pidof
Date: Thu, 08 Mar 2012 13:10:35 -0500	[thread overview]
Message-ID: <20120308181035.GA10587@denix.org> (raw)
In-Reply-To: <1331208530-11938-1-git-send-email-obi@opendreambox.org>

On Thu, Mar 08, 2012 at 01:08:50PM +0100, Andreas Oberritter wrote:
> * pidof lives in /bin, search it in $PATH.

Nice catch! It does indeed live in /bin

> * Assume pidof's presence.
> 
> Signed-off-by: Andreas Oberritter <obi@opendreambox.org>

Acked-by: Denys Dmytriyenko <denys@ti.com>

> ---
>  meta/recipes-core/udev/udev/init   |    6 ++----
>  meta/recipes-core/udev/udev_164.bb |    2 +-
>  2 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/meta/recipes-core/udev/udev/init b/meta/recipes-core/udev/udev/init
> index 78b5b1c..f9e9014 100644
> --- a/meta/recipes-core/udev/udev/init
> +++ b/meta/recipes-core/udev/udev/init
> @@ -28,10 +28,8 @@ readfile () {
>  }
>  
>  kill_udevd() {
> -	if [ -x /sbin/pidof ]; then
> -		pid=`/sbin/pidof -x udevd`
> -		[ -n "$pid" ] && kill $pid
> -	fi
> +	pid=`pidof -x udevd`
> +	[ -n "$pid" ] && kill $pid
>  }
>  
>  export ACTION=add
> diff --git a/meta/recipes-core/udev/udev_164.bb b/meta/recipes-core/udev/udev_164.bb
> index b993a13..d661044 100644
> --- a/meta/recipes-core/udev/udev_164.bb
> +++ b/meta/recipes-core/udev/udev_164.bb
> @@ -1,6 +1,6 @@
>  include udev.inc
>  
> -PR = "r11"
> +PR = "r12"
>  
>  SRC_URI += "file://udev-166-v4l1-1.patch"
>  
> -- 
> 1.7.5.4
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core



  parent reply	other threads:[~2012-03-08 19:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-08 12:08 [PATCH] udev-164: don't hardcode path to pidof Andreas Oberritter
2012-03-08 15:07 ` Otavio Salvador
2012-03-08 18:10 ` Denys Dmytriyenko [this message]
2012-03-08 20:09 ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120308181035.GA10587@denix.org \
    --to=denis@denix.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox