From: Peter Seebach <peter.seebach@windriver.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Cc: Christopher Larson <chris_larson@mentor.com>
Subject: Re: [PATCH 1/3] external-sourcery: extract src and dest sysroot paths from gcc
Date: Thu, 31 May 2012 23:06:33 -0500 [thread overview]
Message-ID: <20120531230633.70344cfb@wrlaptop> (raw)
In-Reply-To: <367a51d945217c0a11caab13e71fe83a557a6872.1338515870.git.chris_larson@mentor.com>
On Thu, 31 May 2012 19:00:04 -0700
Christopher Larson <kergoth@gmail.com> wrote:
> +CSL_MULTILIB_ARGS[i586] = "-msgxx-glibc"
> +CSL_MULTILIB_ARGS[i686] = "-msgxx-glibc"
> +CSL_MULTILIB_ARGS[core2] = "-msgxx-glibc"
> +CSL_MULTILIB_ARGS[x86] = "-msgxx-glibc"
> +CSL_MULTILIB_ARGS[x86-64] = "-msgxx-glibc"
> +CSL_MULTILIB_ARGS[ppce500] = "-te500v1"
> +CSL_MULTILIB_ARGS[ppce500mc] = "-te500mc"
> +CSL_MULTILIB_ARGS[ppce500v2] = "-te500v2"
> +CSL_MULTILIB_ARGS[ppce600] = "-te600"
I would suggest that these be ?= assignments.
Rationale: There is more than one Sourcery toolchain out there, and
they sometimes differ in these. It'd be nice if a hypothetical vendor
using a hypothetical custom variant of the Sourcery toolchain could use
these configuration files with nothing more than a few variable
assignments. :)
I do quite like the cleanup.
-s
--
Listen, get this. Nobody with a good compiler needs to be justified.
next prev parent reply other threads:[~2012-06-01 4:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-01 2:00 [PATCH 0/3] More external toolchain fixes/improvements Christopher Larson
2012-06-01 2:00 ` [PATCH 1/3] external-sourcery: extract src and dest sysroot paths from gcc Christopher Larson
2012-06-01 4:06 ` Peter Seebach [this message]
2012-06-01 13:59 ` Chris Larson
2012-06-01 2:00 ` [PATCH 2/3] tcmode-external-sourcery: pass -msgxx-glibc for x86 Christopher Larson
2012-06-01 2:00 ` [PATCH 3/3] external-sourcery-toolchain: forcibly create usr/lib Christopher Larson
2012-06-01 2:01 ` [PATCH 0/3] More external toolchain fixes/improvements Christopher Larson
-- strict thread matches above, loose matches on Subject: below --
2012-06-01 22:53 [PATCHv2 " Christopher Larson
2012-06-01 22:53 ` [PATCH 1/3] external-sourcery: extract src and dest sysroot paths from gcc Christopher Larson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120531230633.70344cfb@wrlaptop \
--to=peter.seebach@windriver.com \
--cc=chris_larson@mentor.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox