Re: [PATCH 1/3] connman: respect the 3g feature and enable/disable ofono support

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1565 bytes --]

On Thu, Jun 07, 2012 at 03:19:36PM +0100, Ross Burton wrote:
> [YOCTO #2357]
> 
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>  meta/recipes-connectivity/connman/connman.inc |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
> index f2da8d9..58e3f56 100644
> --- a/meta/recipes-connectivity/connman/connman.inc
> +++ b/meta/recipes-connectivity/connman/connman.inc
> @@ -17,7 +17,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
>  DEPENDS  = "dbus glib-2.0 ppp iptables gnutls \
>              ${@base_contains('DISTRO_FEATURES', 'bluetooth','bluez4', '', d)} \
>              ${@base_contains('DISTRO_FEATURES', 'wifi','wpa-supplicant', '', d)} \
> -            ofono \
> +            ${@base_contains('DISTRO_FEATURES', '3g','ofono', '', d)} \
>              "
>  
>  TIST = "--enable-tist"
> @@ -34,7 +34,7 @@ EXTRA_OECONF += "\
>      ${@base_contains('DISTRO_FEATURES', 'wifi','--enable-wifi ${TIST}', '--disable-wifi', d)} \
>      ${@base_contains('DISTRO_FEATURES', 'bluetooth','--enable-bluetooth ${TIST}', '--disable-bluetooth', d)} \
>      --enable-dnsproxy \
> -    --enable-ofono \
> +    ${@base_contains('DISTRO_FEATURES', '3g', '', '--disable-ofono', d)} \
>      --enable-tools \
>      --enable-test \
>      --disable-polkit \

Why not use PACKAGECONFIG for all those?

Cheers,

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]