From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.windriver.com ([147.11.1.11]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1Soavz-0005dW-8Y for openembedded-core@lists.openembedded.org; Tue, 10 Jul 2012 15:56:59 +0200 Received: from yow-afong-lx2.ottawa.windriver.com (yow-afong-lx2.wrs.com [128.224.146.164]) by mail.windriver.com (8.14.3/8.14.3) with ESMTP id q6ADjNQ4023459; Tue, 10 Jul 2012 06:45:24 -0700 (PDT) Received: from afong by yow-afong-lx2.ottawa.windriver.com with local (Exim 4.80) (envelope-from ) id 1Soakk-0005pn-DH; Tue, 10 Jul 2012 09:45:22 -0400 Date: Tue, 10 Jul 2012 09:45:22 -0400 From: Amy Fong To: Saul Wold Message-ID: <20120710134522.GA20217@windriver.com> References: <20120709185017.GA22808@windriver.com> <4FFBAE52.6070301@linux.intel.com> MIME-Version: 1.0 In-Reply-To: <4FFBAE52.6070301@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Patches and discussions about the oe-core layer Subject: Re: [PATCH] package install failure on systems without /sbin/ldconfig X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2012 13:56:59 -0000 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jul 09, 2012 at 09:23:46PM -0700, Saul Wold wrote: > On 07/09/2012 11:50 AM, Amy Fong wrote: > >Package install failures due to issues in post install rules. > > > >package_do_shlibs only looks for libraries in a directory "lib", this should be > >modified to the variable baselib. > > > >ldconfig_postinst_fragment failure observed on systems without /sbin/ldconfig > > [ -x /sbin/ldconfig ] && /sbin/ldconfig > >results in the post install rule returning a failure. Modify to > > if [ -x /sbin/ldconfig ]; then /sbin/ldconfig; fi > > > If this is addressing bug #2723, then please mark it as follows: > > [YOCTO #2723] in the commit message. > > Also the commit subject should include the file name for example: > package.bbclass: fix for package install failure on systems without > /sbin/ldconfig > > Thanks > Sau! > Thanks Saul, updated as follows.... [YOCTO #2723] package.bbclass: fix for package install failure on systems without /sbin/ldconfig package_do_shlibs only looks for libraries in a directory "lib", this should be modified to the variable baselib. ldconfig_postinst_fragment failure observed on systems without /sbin/ldconfig [ -x /sbin/ldconfig ] && /sbin/ldconfig results in the post install rule returning a failure. Modify to if [ -x /sbin/ldconfig ]; then /sbin/ldconfig; fi Signed-off-by: Amy Fong --- package.bbclass | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass index 56ab25c..28a263c 100644 --- a/meta/classes/package.bbclass +++ b/meta/classes/package.bbclass @@ -1151,7 +1151,7 @@ emit_pkgdata[dirs] = "${PKGDESTWORK}/runtime" ldconfig_postinst_fragment() { if [ x"$D" = "x" ]; then - [ -x /sbin/ldconfig ] && /sbin/ldconfig + if [ -x /sbin/ldconfig ]; then /sbin/ldconfig ; fi fi } @@ -1261,7 +1261,7 @@ python package_do_shlibs() { return lib_re = re.compile("^.*\.so") - libdir_re = re.compile(".*/lib$") + libdir_re = re.compile(".*/%s$" % d.getVar('baselib', True)) packages = d.getVar('PACKAGES', True) targetos = d.getVar('TARGET_OS', True)