From: Henning Heinold <heinold@inf.fu-berlin.de>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH V2] chrpath.bbclass: Account for case when ORIGIN is in RPATH
Date: Thu, 16 Aug 2012 08:44:29 +0200 [thread overview]
Message-ID: <20120816064429.GA5122@mi.fu-berlin.de> (raw)
In-Reply-To: <1345086946-3715-1-git-send-email-raj.khem@gmail.com>
On Wed, Aug 15, 2012 at 08:15:46PM -0700, Khem Raj wrote:
> This fixes a case when RPATH embedded in program have one of
> its path already relative to ORIGIN. We were losing that path
> if such a path existed. This patch appends it to the new edited
> rpath being created when we see it.
>
> so RPATH like below
>
> (RPATH) Library rpath:
> [$ORIGIN/../lib/amd64/jli:$ORIGIN/../jre/lib/amd64/jli]
>
> would end up being empty
>
> but after this patch its kept intact
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> meta/classes/chrpath.bbclass | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/chrpath.bbclass b/meta/classes/chrpath.bbclass
> index 10b5ca0..861d369 100644
> --- a/meta/classes/chrpath.bbclass
> +++ b/meta/classes/chrpath.bbclass
> @@ -48,8 +48,9 @@ def process_dir (directory, d):
> rpaths = curr_rpath.split(":")
> new_rpaths = []
> for rpath in rpaths:
> - # If rpath is already dynamic continue
> + # If rpath is already dynamic copy it to new_rpath and continue
> if rpath.find("$ORIGIN") != -1:
> + new_rpaths.append("%s" % (rpath.strip()))
> continue
> # If the rpath shares a root with base_prefix determine a new dynamic rpath from the
> # base_prefix shared root
> --
> 1.7.9.5
Hi Khem,
just notice my solution some months ago
http://patches.openembedded.org/patch/24461/
Bye Henning
next prev parent reply other threads:[~2012-08-16 6:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 3:15 [PATCH V2] chrpath.bbclass: Account for case when ORIGIN is in RPATH Khem Raj
2012-08-16 6:44 ` Henning Heinold [this message]
2012-08-17 16:45 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120816064429.GA5122@mi.fu-berlin.de \
--to=heinold@inf.fu-berlin.de \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox