Re: [PATCH 1/2] make: add make-replacement-native 3.81

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2027 bytes --]

On Thu, Aug 16, 2012 at 10:30:37PM +0200, Andreas Müller wrote:
> On Wed, Aug 15, 2012 at 11:40 PM, Phil Blundell <philb@gnu.org> wrote:
> > On Wed, 2012-08-15 at 22:17 +0100, Burton, Ross wrote:
> >> On 15 August 2012 22:12, Martin Jansa <martin.jansa@gmail.com> wrote:
> >> > eglibc was failing to build with make-3.81
> >> > https://bugzilla.yoctoproject.org/show_bug.cgi?id=2314
> >> >
> >> > so I guess once this is built (as webkit-gtk dependency), eglibc will maybe sometimes fail again..
> >>
> >> Interesting, this is the first time I've encountered 3.81 having
> >> problems.  So we can't use 3.81 and we can't use 3.82 either. :)
> >
> > You can use 3.81, you just need to install it either under a different
> > name (e.g. call it "make-3.81" and set $MAKE) or in a different
> > directory (e.g. ${bindir}/make-3.81/make and set $PATH) so that other
> > recipes don't pick it up unexpectedly.
> >
> > p.
> >
> The following is really dirty but at least to me it succeeds and to me
> it seems to have less influences than the 'make 3.81 dance':
> 
> # dirty hack for gnu make 3.82 race condition
> do_compile() {
>     if [ x"$MAKE" = x ]; then MAKE=make; fi
>     bbnote make ${PARALLEL_MAKE} "$@"
>     for error_count in 1 2 3; do
>         bbnote "Number of trials: $error_count"
>         exit_code=0
>         make ${PARALLEL_MAKE} "$@" || exit_code=1
>         if [ $exit_code = 0 ]; then
>             break
>         fi
>     done
>     if [ ! $exit_code = 0 ]; then
>         die "oe_runmake failed"
>     fi
> }
> 
> I have make 3.82 and before this I had 100% error at first do_compile.
> For rerun (without cleanup) I had 100% success. Now I get 100% success
> with make called twice. Would something like have a chance to be
> accepted?

Same for me, except I didn't go that far to reexecute make from recipe,
just executing feed build twice in for loop to be sure it will succeed.

Cheers,

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]