From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wg0-f43.google.com ([74.125.82.43]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1T2Lbx-00040I-7t for openembedded-core@lists.openembedded.org; Fri, 17 Aug 2012 14:25:09 +0200 Received: by wgbdr1 with SMTP id dr1so2945740wgb.24 for ; Fri, 17 Aug 2012 05:13:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=QeypHLnQ4Ko4CxpNm6vwuB8ZKGHFoG53SQ0D/3Co8j8=; b=bnORunldIhxo49k4GQVOSeUFAp/DXk4FUSoT1JwJB1AhmZ6Xu0XshAFRVL0UDbgWoK VRIq5oF4OYQR19LEJnUXVsXUqCT+n5Sgq9yi7AgkZJDhkdbX5O2eh/Qe2UYTYac9cI9e TwRl6eafQPnLTyUG6nWBnDg+WN5bF3Z3qh3zj/aAWf0b5u6BP6reXuccpMAY9kTzeDvr ++iBJrWlU3xl6izRSA7AwM9kZakrGj9LENaxhWZQCInDkC6PLJPStwrUBJLCs+UpqDKF qiQPgFa2Rs79/7IDRWVBm5LIVW7qCMdpxDCaQHvrojqIIqye8Ifd8/L1IbkfQfZ7k/zo 0Kzw== Received: by 10.216.232.204 with SMTP id n54mr2588199weq.182.1345205590884; Fri, 17 Aug 2012 05:13:10 -0700 (PDT) Received: from localhost ([94.230.152.246]) by mx.google.com with ESMTPS id bc2sm14131712wib.0.2012.08.17.05.13.09 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 17 Aug 2012 05:13:09 -0700 (PDT) Date: Fri, 17 Aug 2012 14:13:07 +0200 From: Martin Jansa To: Patches and discussions about the oe-core layer Message-ID: <20120817121307.GG3625@jama.jama.net> References: MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [PATCH 1/1] apr-util: fix the rules.mk with path to sysroot instead of the workdir of apr X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Aug 2012 12:25:09 -0000 X-Groupsio-MsgNum: 27705 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8bBEDOJVaa9YlTAt" Content-Disposition: inline --8bBEDOJVaa9YlTAt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 17, 2012 at 11:11:43AM +0800, jackie.huang@windriver.com wrote: > From: Jackie Huang >=20 > The copying for rules.mk was happened in do_configure_prepend, but it wil= l be > replaced by the one generated by configure, in which APR_MKEXPORT points = to > the workdir of apr and cause compile filure when the workdir of apr is re= moved. > So change the copying in _prepend to _append. >=20 > [YOCTO #2947] >=20 > Signed-off-by: Jackie Huang > --- > meta/recipes-support/apr/apr-util_1.4.1.bb | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/meta/recipes-support/apr/apr-util_1.4.1.bb b/meta/recipes-su= pport/apr/apr-util_1.4.1.bb > index deb608f..0516bc4 100644 > --- a/meta/recipes-support/apr/apr-util_1.4.1.bb > +++ b/meta/recipes-support/apr/apr-util_1.4.1.bb > @@ -32,8 +32,10 @@ inherit autotools lib_package binconfig > =20 > OE_BINCONFIG_EXTRA_MANGLE =3D " -e 's:location=3Dsource:location=3Dinsta= lled:'" > =20 > -do_configure_prepend() { > - cp ${STAGING_DATADIR}/apr/apr_rules.mk ${S}/build/rules.mk > +do_configure_append() { > + if [ "${PN}" =3D=3D "${BPN}" ]; then > + cp ${STAGING_DATADIR}/apr/apr_rules.mk ${S}/build/rules.mk > + fi > } > do_configure_prepend_virtclass-native() { > cp ${STAGING_DATADIR_NATIVE}/apr/apr_rules.mk ${S}/build/rules.mk Why is it different then native case above? Shouldn't be the same fix prepend/append applied for native case too and then "${PN}" =3D=3D "${BPN}" won't be needed? Cheers, --=20 Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com --8bBEDOJVaa9YlTAt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iEYEARECAAYFAlAuNVMACgkQN1Ujt2V2gBxf+QCgj78X9DKdn+EOI8kcRPfM+juR Y7QAn0MAZKMYL0l02hOM8C9H50VheGZl =4ba2 -----END PGP SIGNATURE----- --8bBEDOJVaa9YlTAt--