From: Martin Jansa <martin.jansa@gmail.com>
To: Tomas Frydrych <tf+lists.yocto@r-finger.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: runstrip() in package.bbclass fails when run against a kernel module
Date: Mon, 3 Sep 2012 09:08:32 +0200 [thread overview]
Message-ID: <20120903070832.GC3205@jama.jama.net> (raw)
In-Reply-To: <5040A5BB.7040601@r-finger.com>
[-- Attachment #1: Type: text/plain, Size: 2067 bytes --]
On Fri, Aug 31, 2012 at 12:53:31PM +0100, Tomas Frydrych wrote:
>
> runstrip() in package.bbclass fails when run against a kernel module,
> because it tries to do a bitwise & with a 'None' argument. This throws:
> TypeError: unsupported operand type(s) for &: 'NoneType' and 'int'.
>
> (This bug triggers, for example, when building ti-linuxutils from
> meta-ti (v2012.05-yocto1.2 tag) against Denzil.)
>
> Patch attached.
Was this for denzil?
In master it was fixed a month ago by:
http://git.openembedded.org/openembedded-core/commit/meta/classes/package.bbclass?id=a834ab8a6d53cae504fa112a89bab93d726539ec
Don't know why they merged your patch to master too now..
Cheers,
>
> Tomas
>
> From 6abe978d8e0acdb35c1abfed83e775b276b1231f Mon Sep 17 00:00:00 2001
> From: Tomas Frydrych <tomas@sleepfive.com>
> Date: Fri, 31 Aug 2012 12:02:18 +0100
> Subject: [PATCH] package.bbclass: fix stripping for kernel modules
>
> runstrip(path, elftype, d) does bitwise & on the elftype parameter, so it has
> to be passed an integer. Passing None fails with: TypeError: unsupported
> operand type(s) for &: 'NoneType' and 'int'.
>
> Signed-off-by: Tomas Frydrych <tomas@sleepfive.com>
> ---
> meta/classes/package.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
> index 44e551f..f046fbb 100644
> --- a/meta/classes/package.bbclass
> +++ b/meta/classes/package.bbclass
> @@ -877,7 +877,7 @@ python split_and_strip_files () {
> for f in files:
> if not f.endswith(".ko"):
> continue
> - runstrip(os.path.join(root, f), None, d)
> + runstrip(os.path.join(root, f), 0, d)
> #
> # End of strip
> #
> --
> 1.7.10.4
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
next prev parent reply other threads:[~2012-09-03 7:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 11:53 runstrip() in package.bbclass fails when run against a kernel module Tomas Frydrych
2012-09-03 7:08 ` Martin Jansa [this message]
2012-09-04 9:12 ` Tomas Frydrych
2012-09-04 9:23 ` Martin Jansa
2012-09-04 9:53 ` Tomas Frydrych
2012-09-05 16:18 ` Scott Garman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120903070832.GC3205@jama.jama.net \
--to=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=tf+lists.yocto@r-finger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox