Re: [PATCH] gypsy: removed gypsy from meta/recipes-connectivity

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 4800 bytes --]

On Wed, Oct 24, 2012 at 11:20:52AM +0300, Andrei Dinu wrote:
> The newer code points to :
> 
> commit be8c9c382d2d1d37b51d29b0843045121ec90213
> Author: iain <iain@sleepfive.com>
> Date:   Tue Aug 28 12:31:42 2012 +0100
> 
>      Configure automake to generate .gz and .bz2 archives
> 
> This is the latest commit in the gypsy git master branch.
> 
> Also, the lastest release is pointed here :
> http://gypsy.freedesktop.org/releases/
> 
> and it is on the same date as the last commit in git.
> 
> I don't really know how git recipes work, do you suggest updating the PV ?

Yes, now it says
PV = "0.8+git${SRCPV}"

but this commit you added to SRCREV has the same code as 0.9 release,
maybe more when someone changes SRCREV next time, so change PV to
PV = "0.9+git${SRCPV}"

But I don't understand why recipe for 0.9 release was removed, because 
looking at it, it seems exactly the same as this SRCREV. Maybe it was 
repackaged later?

Ah I see, Ross wrote that bug report when there wasn't 0.9 yet.

So fix PV in git recipe and return back 0.9 recipe.

martin@jama ~ $ diff -rq gypsy gypsy-0.9
Only in gypsy-0.9: aclocal.m4
Only in gypsy: autogen.sh
Only in gypsy-0.9: config.guess
Only in gypsy-0.9: config.h.in
Only in gypsy-0.9: config.sub
Only in gypsy-0.9: configure
Only in gypsy-0.9: .configure.ac.swp
Only in gypsy-0.9: depcomp
Only in gypsy-0.9/docs: Makefile.in
Only in gypsy-0.9/docs/reference: gypsy-overrides.txt
Only in gypsy-0.9/docs/reference: html
Only in gypsy-0.9/docs/reference: Makefile.in
Only in gypsy-0.9/docs/reference: ref-gypsy-client.xml
Only in gypsy-0.9/docs/reference: ref-gypsy-server.xml
Only in gypsy-0.9/docs/reference: tmpl
Only in gypsy-0.9/docs/reference: version.xml
Only in gypsy-0.9/docs/tools: Makefile.in
Only in gypsy/docs: why-not-gpsd.html
Only in gypsy-0.9/etc: Makefile.in
Only in gypsy-0.9/examples: Makefile.in
Only in gypsy: .git
Only in gypsy: .gitignore
Only in gypsy-0.9: gtk-doc.make
Only in gypsy-0.9/gypsy: gypsy-client-bindings.h
Only in gypsy-0.9/gypsy: gypsy-discovery-bindings.h
Only in gypsy-0.9/gypsy: gypsy-marshal.c
Only in gypsy-0.9/gypsy: gypsy-marshal.h
Only in gypsy-0.9/gypsy: gypsy-server-bindings.h
Only in gypsy-0.9/gypsy: Makefile.in
Only in gypsy-0.9: Gypsy.conf
Only in gypsy: HACKING
Only in gypsy-0.9: install-sh
Only in gypsy-0.9/interfaces: Makefile.in
Only in gypsy-0.9: ltmain.sh
Only in gypsy-0.9: m4
Only in gypsy-0.9: Makefile.in
Only in gypsy-0.9: missing
Only in gypsy-0.9/src: gypsy-client-glue.h
Only in gypsy-0.9/src: gypsy-discovery-glue.h
Only in gypsy-0.9/src: gypsy-marshal-internal.c
Only in gypsy-0.9/src: gypsy-marshal-internal.h
Only in gypsy-0.9/src: gypsy-server-glue.h
Only in gypsy-0.9/src: Makefile.in

> On 10/24/2012 11:00 AM, Martin Jansa wrote:
> > On Wed, Oct 24, 2012 at 10:46:08AM +0300, Andrei Dinu wrote:
> >> Hi Martin,
> >>
> >> This change was caused by the bug :
> >>
> >> https://bugzilla.yoctoproject.org/show_bug.cgi?id=2797
> >>
> >> I removed the tarball and kept only the git package because that is what
> >> says in the bug.
> >>
> >> Secondly, i modified the SRCREV because i took the latest version in the
> >> git repo.
> > Hi,
> >
> > So this SRCREV points to newer code then 0.9 now? Then you forgot to
> > update PV to say so.
> >
> > That's why there is error about downgrading it.
> >
> > Cheers,
> >   
> >> If there is anything more to add please send me an email.
> >>
> >> Thanks,
> >>
> >> Andrei Dinu
> >>
> >> On 10/23/2012 09:54 PM, Martin Jansa wrote:
> >>> On Thu, Oct 18, 2012 at 10:59:48PM +0200, Martin Jansa wrote:
> >>>> On Thu, Oct 18, 2012 at 08:59:19PM +0200, Martin Jansa wrote:
> >>>>> I know you've sent
> >>>>> http://patchwork.openembedded.org/patch/37763/
> >>>>> to add it to meta-oe, but this patch removed also newer gypsy_0.9.bb
> >>>>> and only older gypsy_git.bb was added back.
> >>>>>
> >>>>> Please fix that.
> >>>> There is also this diff which isn't mentioned in your commit.
> >>>>
> >>>> -SRCREV = "3652e1f37e82b8e63983e30fda3482cd099a8cf5"
> >>>> +SRCREV = "be8c9c382d2d1d37b51d29b0843045121ec90213"
> >>>>    PV = "0.8+git${SRCPV}"
> >>>>    PR = "r2"
> >>>>
> >>>> @@ -15,4 +15,5 @@
> >>>>                        file://gypsy/gypsy-time.h;beginline=1;endline=24;md5=06432ea19a7b6607428d04d9dadc37fd"
> >>>>
> >>>>    SRC_URI = "git://anongit.freedesktop.org/gypsy;protocol=git \
> >>>> -           file://fixups.patch"
> >>>> +           file://fixups.patch \
> >>>> +           file://0001-gypsy-m4-directory-missing-from-structure.patch"
> >>> ping
> >>>
> >>> meta-oe is still broken because of this
> >>>
> >>> Cheers,
> 

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]