Re: [PATCHv4] scripts/sstate-sysroot-cruft.sh: add simple script to find files in sysroots not tracked by sstate

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2387 bytes --]

On Thu, Nov 15, 2012 at 08:25:20AM -0700, Chris Larson wrote:
> On Thu, Nov 15, 2012 at 12:30 AM, Martin Jansa <martin.jansa@gmail.com>wrote:
> 
> > * it's not very universal, but works with default oe-core setup and
> >   shows basic HOW-TO. It can be improved later.
> >
> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > ---
> >  V2: added .pyo to WHITELIST
> >      shorter filenames
> >      TMPDIR
> >      added duplicates but not shown
> >
> >  V3: use also populate-sysroot.MACHINE, manifest name for populate-sysroot
> >      was changed in febeaf3d1b8917b660c7279b008d8b03337568e9
> >
> >  V4: dropped eglibc-initial work around, it was fixed in oe-core
> >
> >  scripts/sstate-sysroot-cruft.sh | 34 ++++++++++++++++++++++++++++++++++
> >  1 file changed, 34 insertions(+)
> >  create mode 100755 scripts/sstate-sysroot-cruft.sh
> >
> > diff --git a/scripts/sstate-sysroot-cruft.sh
> > b/scripts/sstate-sysroot-cruft.sh
> > new file mode 100755
> > index 0000000..ca23dcf
> > --- /dev/null
> > +++ b/scripts/sstate-sysroot-cruft.sh
> > @@ -0,0 +1,34 @@
> > +#!/bin/sh
> > +
> > +# Used to find files installed in sysroot which are not tracked by sstate
> > manifest
> > +# Update BASE
> > +
> > +BASE="/OE/oe-core"
> >
> 
> This seems interesting, but I have a few comments/concerns.
> 
> 1) don't hardcode BASE, figure out the path relative to the script's
> location, e.g. BASE="$(cd $(dirname $(dirname $0)) && pwd)"
> 2) output files shouldn't go into oe-core directly, as oe-core isn't
> guaranteed to be writable, and it's more common to expect output from a
> script like this to go relative to the current directory, or a temp
> directory
> 3) extract TMPDIR from bitbake -e, rather than hardcoding that, as that
> breaks for any distros or users which separate their tmpdirs by distro, or
> set TCLIBCAPPEND = ""

Ah in this case BASE is not directory with oe-core layer but one above.

I didn't want to use bitbake -e, so that this script can be executed
when some other bitbake process is running.

As said it's not really universal (I wrote it just to confirm something
and then shared it to find if someone else finds it also usefull to
improve it).

What about moving output to TMPDIR and setting TMPDIR by parameter?

Cheers,

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]