From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] gtk-icon-cache: don't call gtk-update-icon-cache on files
Date: Sat, 22 Dec 2012 21:14:18 +0100 [thread overview]
Message-ID: <20121222201418.GE8988@jama.palm1.palmone.com> (raw)
In-Reply-To: <1356206329-12627-1-git-send-email-Martin.Jansa@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1912 bytes --]
On Sat, Dec 22, 2012 at 08:58:49PM +0100, Martin Jansa wrote:
> * check if icondir is directory before calling gtk-update-icon-cache, like all other calls do
> * fixes:
> | > Executing update_icon_cache
> | + chmod +x update_icon_cache
> | + ./update_icon_cache
> | gtk-update-icon-cache.real: Failed to open file /tmp-eglibc/work/qemuarm-oe-linux-gnueabi/shr-image-all/2.0-r20/rootfs/usr/share/icons/enjoy.png/.icon-theme.cache : Not a directory
> | gtk-update-icon-cache.real: Failed to open file /tmp-eglibc/work/qemuarm-oe-linux-gnueabi/shr-image-all/2.0-r20/rootfs/usr/share/icons/monav.png/.icon-theme.cache : Not a directory
> | gtk-update-icon-cache.real: Failed to open file /tmp-eglibc/work/qemuarm-oe-linux-gnueabi/shr-image-all/2.0-r20/rootfs/usr/share/icons/orrery.png/.icon-theme.cache : Not a directory
Be aware that you need to manually remove
$INTERCEPT_DIR/update_icon_cache
otherwise such broken script is kept forever
gtk_icon_cache_postinst() {
if [ "x$D" != "x" ]; then
if [ ! -f $INTERCEPT_DIR/update_icon_cache ]; then
cat << "EOF" > $INTERCEPT_DIR/update_icon_cache
>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
> meta/classes/gtk-icon-cache.bbclass | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/gtk-icon-cache.bbclass b/meta/classes/gtk-icon-cache.bbclass
> index f87a30f..7c7dd78 100644
> --- a/meta/classes/gtk-icon-cache.bbclass
> +++ b/meta/classes/gtk-icon-cache.bbclass
> @@ -12,7 +12,9 @@ if [ "x$D" != "x" ]; then
> gdk-pixbuf-query-loaders --update-cache
>
> for icondir in $D/usr/share/icons/*/ ; do
> - gtk-update-icon-cache -fqt $icondir
> + if [ -d $icondir ] ; then
> + gtk-update-icon-cache -fqt $icondir
> + fi
> done
> EOF
> fi
> --
> 1.8.0.2
>
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
prev parent reply other threads:[~2012-12-22 20:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-22 19:58 [PATCH] gtk-icon-cache: don't call gtk-update-icon-cache on files Martin Jansa
2012-12-22 20:14 ` Martin Jansa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121222201418.GE8988@jama.palm1.palmone.com \
--to=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox