Re: [oe-commits] Robert P. J. Day : kernel.bbclass: Define MODULE_IMAGE_BASE_NAME for layer convenience.

Robert P. J. Day
2013-01-17T15:44:20Z

On Thu, 17 Jan 2013, Martin Jansa wrote:

> On Thu, Jan 10, 2013 at 11:52:38PM +0000, git@git.openembedded.org wrote:
> > Module: openembedded-core.git
> > Branch: master
> > Commit: 67e77cd948c69798695d5d5f34163ef89339b35a
> > URL: http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=67e77cd948c69798695d5d5f34163ef89339b35a
> >
> > Author: Robert P. J. Day <rpjday@crashcourse.ca>
> > Date: Wed Jan 9 12:01:23 2013 -0500
> >
> > kernel.bbclass: Define MODULE_IMAGE_BASE_NAME for layer convenience.
> >
> > Define the additional variable MODULE_IMAGE_BASE_NAME since some
> > layers (like meta-ti) would find it handy for multi-kernel
> > definitions in that they wouldn't have to define their own
> > variable representing exactly the same thing.
> >
> > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> > Signed-off-by: Saul Wold <sgw@linux.intel.com>
> >
> > ---
> >
> > meta/classes/kernel.bbclass | 3 ++-
> > 1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> > index aff8842..46ba55f 100644
> > --- a/meta/classes/kernel.bbclass
> > +++ b/meta/classes/kernel.bbclass
> > @@ -500,7 +500,8 @@ KERNEL_IMAGE_BASE_NAME ?= "${KERNEL_IMAGETYPE}-${PE}-${PV}-${PR}-${MACHINE}-${DA
> > # Don't include the DATETIME variable in the sstate package signatures
> > KERNEL_IMAGE_BASE_NAME[vardepsexclude] = "DATETIME"
> > KERNEL_IMAGE_SYMLINK_NAME ?= "${KERNEL_IMAGETYPE}-${MACHINE}"
> > -MODULE_TARBALL_BASE_NAME ?= "modules-${PE}-${PV}-${PR}-${MACHINE}-${DATETIME}.tgz"
> > +MODULE_IMAGE_BASE_NAME ?= "modules-${PE}-${PV}-${PR}-${MACHINE}-${DATETIME}"
> > +MODULE_TARBALL_BASE_NAME ?= "${MODULE_IMAGE_BASE_NAME}.tgz"
> > # Don't include the DATETIME variable in the sstate package signatures
> > MODULE_TARBALL_BASE_NAME[vardepsexclude] = "DATETIME"
> > MODULE_TARBALL_SYMLINK_NAME ?= "modules-${MACHINE}.tgz"
>
> This makes sstate checksums to depend on DATETIME variable.
> https://bugzilla.yoctoproject.org/show_bug.cgi?id=3299

yes, i see your point, my mistake in not noticing that when i
submitted that patch. would someone else like to handle this just to
make sure it's fixed correctly?

rday

--

========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca

Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================