public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Peter Seebach <peter.seebach@windriver.com>
To: "Openembedded-core@lists.openembedded.org"
	<Openembedded-core@lists.openembedded.org>
Subject: Is this a bug? Installed-but-not-packaged warning for a file which is in a package
Date: Wed, 23 Jan 2013 14:43:20 -0600	[thread overview]
Message-ID: <20130123144320.191c91a3@e6410-2> (raw)

FILES_${PN} = "fascinating"

do_install() {
	touch ${D}/fascinating
}

At least in our local copy of oe-core, this results in:

1. A package which contains a /fascinating file.
2. An installed-but-unpackaged warning for /fascinating.

This confused the heck out of me. I eventually figured it out: The "not
in seen" test is not aware of the possibility of differing path names.
In general, all path names in FILES_* are being written as absolute
paths by convention; in the actual code, this is silently corrected by
the addition of a leading period.

But an unqualified path works; it's treated as relative to the
sysroot/image/whatever, and it has the expected behavior. But then we
insert "fascinating" in seen, and check for "./fascinating" in the next
phase.

Possible solution:

diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index b06cca5..9d50a61 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -981,6 +981,8 @@ python populate_packages () {
                 file.replace("//", "/")
             if os.path.isabs(file):
                 file = '.' + file
+            if not file.startswith("./")
+                fle = './' + file
             if not os.path.islink(file):
                 if os.path.isdir(file):

Before I send this as an actual patch and such: Is this behavior a bug?
If it is a bug, is this the right fix, or should we do something else,
like reject non-absolute paths?

Note that just adding a / to files that don't start with one doesn't
work; there appear to be at least *some* non-absolute paths in some
packages.

-s
-- 
Listen, get this.  Nobody with a good compiler needs to be justified.



             reply	other threads:[~2013-01-23 20:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-23 20:43 Peter Seebach [this message]
2013-01-24 20:05 ` Is this a bug? Installed-but-not-packaged warning for a file which is in a package Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130123144320.191c91a3@e6410-2 \
    --to=peter.seebach@windriver.com \
    --cc=Openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox