From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.windriver.com ([147.11.1.11]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1U2oFL-0004kw-6p for openembedded-core@lists.openembedded.org; Tue, 05 Feb 2013 20:32:00 +0100 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.14.5/8.14.3) with ESMTP id r15JG3g4003913 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Tue, 5 Feb 2013 11:16:03 -0800 (PST) Received: from e6410-2 (172.25.40.227) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.2.318.4; Tue, 5 Feb 2013 11:16:03 -0800 Date: Tue, 5 Feb 2013 13:15:55 -0600 From: Peter Seebach To: Constantin Musca Message-ID: <20130205131555.46c685fb@e6410-2> In-Reply-To: <5110B6CE.1050504@intel.com> References: <1359977606-15432-1-git-send-email-constantinx.musca@intel.com> <20130204122309.12582d0b@e6410-2> <1360020111.14071.172.camel@ted> <20130204172705.0e18d279@e6410-2> <1360021079.14071.174.camel@ted> <20130204175024.3af7b9b2@e6410-2> <5110B6CE.1050504@intel.com> X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; x86_64-pc-linux-gnu) MIME-Version: 1.0 Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH] pseudo: fix sqlite path and package missing files X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Feb 2013 19:32:02 -0000 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit On Tue, 5 Feb 2013 09:37:50 +0200 Constantin Musca wrote: > On 02/05/2013 01:50 AM, Peter Seebach wrote: > > On Mon, 4 Feb 2013 23:37:59 +0000 > > Richard Purdie wrote: > > > >> Agreed. Can someone send me a patch which makes it all work > >> please? :) > > I probably can. I think the 1.4.3 patch I sent out recently (sgw was > > looking at it, but the binaries weren't up on the downloads server > > yet) probably covers most of it, but not the case where > > sqlite-libdir isn't lib, which is probably (??) a target-only case. > > > > Can someone show me a test case where it fails, so I can add that > > to my pile of pseudo test cases, and then stare at it for a while? > > > > -s > Here's a test case: > 1. local.conf: > MACHINE = "qemux86-64" > require conf/multilib.conf > MULTILIBS = "multilib:lib32" > DEFAULTTUNE_virtclass-multilib-lib32 = "x86" > > 2. build pseudo *pulls off mask, revealing he was the pseudo maintainer all along* And I would have gotten away with it, too, if it hadn't been for you meddling multilibs! Okay, got a tentative fix for this in my tree, will probably resend my pseudo 1.4.3 patch with this changed, once it makes it through my ever-growing collection of pseudo tests. The guts of the change: [...] +SQLITE_LIB = "${baselib}" +SQLITE_LIB_native = "lib" + # Compile for the local machine arch... do_compile () { if [ "${SITEINFO_BITS}" = "64" ]; then - ${S}/configure --prefix=${prefix} --libdir=${prefix}/lib/pseudo/lib${SITEINFO_BITS} --with-sqlite=${STAGING_DIR_TARGET}${exec_prefix} --cflags="${CFLAGS}" --bits=${SITEINFO_BITS} --enable-static-sqlite --without-rpath + ${S}/configure --prefix=${prefix} --libdir=${prefix}/lib/pseudo/lib${SITEINFO_BITS} --with-sqlite-lib=${SQLITE_LIB} --with-sqlite=${STAGING_DIR_TARGET}${exec_prefix} --cflags="${CFLAGS}" --bits=${SITEINFO_BITS} --enable-static-sqlite --without-rpath else This appears to be working for all the cases I've tried. -s -- Listen, get this. Nobody with a good compiler needs to be justified.