From: Martin Jansa <martin.jansa@gmail.com>
To: ml@communistcode.co.uk
Cc: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCHv2] packagegroup-core-boot: add VIRTUAL-RUNTIME_network_manager
Date: Fri, 8 Feb 2013 16:50:20 +0100 [thread overview]
Message-ID: <20130208155020.GN3271@jama> (raw)
In-Reply-To: <1360336833-14523-1-git-send-email-ml@communistcode.co.uk>
[-- Attachment #1: Type: text/plain, Size: 2946 bytes --]
On Fri, Feb 08, 2013 at 03:20:33PM +0000, ml@communistcode.co.uk wrote:
> From: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
>
> Now netbase has been split into netbase and init-ifupdown, the user should
> be able to make a choice on which network manager to install, and not be
> forced to install init-ifupdown alongside if they wish to use a vanilla copy
> of packagegroup-core-boot
>
> v2:
> - Update packagage-core-x11-sato to use the new variable
>
> Signed-off-by: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
> ---
> meta/recipes-core/packagegroups/packagegroup-core-boot.bb | 3 ++-
> meta/recipes-sato/packagegroups/packagegroup-core-x11-sato.bb | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-core/packagegroups/packagegroup-core-boot.bb b/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
> index b9183a8..a714879 100644
> --- a/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
> +++ b/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
> @@ -29,6 +29,7 @@ VIRTUAL-RUNTIME_login_manager ?= "tinylogin"
> VIRTUAL-RUNTIME_init_manager ?= "${DISTRO_FEATURES_INITMAN}"
> VIRTUAL-RUNTIME_initscripts ?= "${@base_contains('DISTRO_FEATURES', 'sysvinit', 'initscripts', '',d)}"
> VIRTUAL-RUNTIME_keymaps ?= "keymaps"
> +VIRTUAL-RUNTIME_network_manager ?= "init-ifupdown"
>
> RDEPENDS_${PN} = "\
> base-files \
> @@ -38,7 +39,7 @@ RDEPENDS_${PN} = "\
> ${@base_contains("MACHINE_FEATURES", "keyboard", "${VIRTUAL-RUNTIME_keymaps}", "", d)} \
> modutils-initscripts \
> netbase \
> - init-ifupdown \
> + ${VIRTUAL-RUNTIME_network_manager} \
> ${VIRTUAL-RUNTIME_login_manager} \
> ${VIRTUAL-RUNTIME_init_manager} \
> ${VIRTUAL-RUNTIME_initscripts} \
> diff --git a/meta/recipes-sato/packagegroups/packagegroup-core-x11-sato.bb b/meta/recipes-sato/packagegroups/packagegroup-core-x11-sato.bb
> index a4413be..7c000ab 100644
> --- a/meta/recipes-sato/packagegroups/packagegroup-core-x11-sato.bb
> +++ b/meta/recipes-sato/packagegroups/packagegroup-core-x11-sato.bb
> @@ -26,6 +26,8 @@ RDEPENDS_${PN} = "\
> NETWORK_MANAGER ?= "connman-gnome"
> NETWORK_MANAGER_libc-uclibc = ""
>
> +VIRTUAL-RUNTIME_network_manager = "${NETWORK_MANAGER}"
Please use ?= here too
> +
> SUMMARY_${PN}-base = "Sato desktop - base packages"
> RDEPENDS_${PN}-base = "\
> matchbox-desktop \
> @@ -40,7 +42,6 @@ RDEPENDS_${PN}-base = "\
> gtk-sato-engine \
> shutdown-desktop \
> libsdl \
> - ${NETWORK_MANAGER} \
> "
>
> # pcmanfm doesn't work on mips
> --
> 1.8.1.2
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
next prev parent reply other threads:[~2013-02-08 16:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 14:36 New netbase changes Jack Mitchell
2013-02-08 14:55 ` [PATCH] packagegroup-core-boot: add VIRTUAL-RUNTIME_network_manager ml
2013-02-08 15:05 ` Burton, Ross
2013-02-08 15:20 ` [PATCHv2] " ml
2013-02-08 15:50 ` Martin Jansa [this message]
2013-02-08 15:56 ` Jack Mitchell
2013-02-08 15:54 ` Burton, Ross
2013-02-08 16:53 ` Otavio Salvador
2013-02-11 11:18 ` Jack Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130208155020.GN3271@jama \
--to=martin.jansa@gmail.com \
--cc=jack.mitchell@dbbroadcast.co.uk \
--cc=ml@communistcode.co.uk \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox