public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: Saul Wold <sgw@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 5/8] busybox: add ifup's ifstate dir to package
Date: Tue, 12 Feb 2013 10:14:09 +0100	[thread overview]
Message-ID: <20130212091409.GA20419@mx.loc> (raw)
In-Reply-To: <5119D737.3000309@linux.intel.com>

On Mon, Feb 11, 2013 at 09:46:31PM -0800, Saul Wold wrote:
>On 02/05/2013 07:55 AM, Bernhard Reutner-Fischer wrote:
>>ifupdown stores its ifstate into CONFIG_IFIPDOWN_IFSTATE_PATH.
>>Fixes:
>>ifup: can't open '/var/run/ifstate': No such file or directory
>>
>>Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
>>---
>>  meta/recipes-core/busybox/busybox.inc |    4 ++++
>>  1 file changed, 4 insertions(+)
>>
>>diff --git a/meta/recipes-core/busybox/busybox.inc b/meta/recipes-core/busybox/busybox.inc
>>index 972e7d0..972df6d 100644
>>--- a/meta/recipes-core/busybox/busybox.inc
>>+++ b/meta/recipes-core/busybox/busybox.inc
>>@@ -199,6 +199,10 @@ do_install () {
>>                         install -m 644 ${WORKDIR}/mdev.conf ${D}${sysconfdir}/mdev.conf
>>                 fi
>>  	fi
>>+	IFUPDOWN_IFSTATE_PATH=`awk '/^CONFIG_IFUPDOWN_IFSTATE_PATH/{split($0,x,/=/);p=x[2];gsub("\"","",p);print p;}' ${WORKDIR}/defconfig`
>>+	if test -n "$IFUPDOWN_IFSTATE_PATH"; then
>Should this also be ${D} in the test, other wise you might be testing
>the host!

WORKDIR is correct, see meta/conf/bitbake.conf setting WORKDIR.
thanks,
>
>
>Sau!
>
>>+		install -m 0755 -d ${D}/"$IFUPDOWN_IFSTATE_PATH"
>>+	fi
>>  	install -m 0644 ${S}/busybox.links ${D}${sysconfdir}
>>  }
>>
>>



  reply	other threads:[~2013-02-12  9:30 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-05 15:55 [PATCH 0/8] misc tweaks Bernhard Reutner-Fischer
2013-02-05 15:55 ` [PATCH 1/8] base.bbclass: Commentary typo fix Bernhard Reutner-Fischer
2013-02-05 15:55 ` [PATCH 2/8] uclibc: add c6x arch Bernhard Reutner-Fischer
2013-02-05 15:55 ` [PATCH 3/8] uclibc: turn on kernel module support Bernhard Reutner-Fischer
2013-02-05 15:55 ` [PATCH 4/8] Revert "Add ptest for glib." Bernhard Reutner-Fischer
2013-02-05 16:44   ` Richard Purdie
2013-02-05 16:44   ` Burton, Ross
2013-02-05 16:47     ` Bernhard Reutner-Fischer
2013-02-05 16:59       ` Burton, Ross
2013-02-05 17:17         ` Bernhard Reutner-Fischer
2013-02-08  8:21           ` Björn Stenberg
2013-02-05 16:46   ` Saul Wold
2013-02-05 17:13     ` Bernhard Reutner-Fischer
2013-02-05 18:39       ` Saul Wold
2013-02-05 19:16         ` Bernhard Reutner-Fischer
2013-02-05 19:36           ` Bernhard Reutner-Fischer
2013-02-05 19:59             ` Saul Wold
2013-02-06  0:01               ` Khem Raj
2013-02-06  9:02         ` Björn Stenberg
2013-02-05 15:55 ` [PATCH 5/8] busybox: add ifup's ifstate dir to package Bernhard Reutner-Fischer
2013-02-12  5:46   ` Saul Wold
2013-02-12  9:14     ` Bernhard Reutner-Fischer [this message]
2013-02-05 15:55 ` [PATCH 6/8] busybox: update-modules script needs id(1) Bernhard Reutner-Fischer
2013-02-05 16:38   ` Richard Purdie
2013-02-05 16:46     ` Bernhard Reutner-Fischer
2013-02-05 15:55 ` [PATCH 7/8] base.bbclass: remove redundant setting of MAKE Bernhard Reutner-Fischer
2013-02-05 15:55 ` [PATCH 8/8] create-pull-request: Error message on missing -u Bernhard Reutner-Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130212091409.GA20419@mx.loc \
    --to=rep.dot.nop@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=sgw@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox