From: Martin Jansa <martin.jansa@gmail.com>
To: Rich Dubielzig <rich.dubielzig@windriver.com>
Cc: Openembedded-core@lists.openembedded.org
Subject: Re: [PATCH V2] pulseaudio: Specify gdbm in configure
Date: Fri, 1 Mar 2013 23:45:38 +0100 [thread overview]
Message-ID: <20130301224538.GV3279@jama> (raw)
In-Reply-To: <1362177552-10996-1-git-send-email-rich.dubielzig@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 1943 bytes --]
On Fri, Mar 01, 2013 at 02:39:12PM -0800, Rich Dubielzig wrote:
> The OE code as-is makes pulseaudio depend on gdbm, but the actual configure
> process may automatically select the tdb library if a samba build has already
> started. This is problematic because it's nondeterministic and the samba
> build may not be in a completed state causing compile to fail.
>
> Signed-off-by: Rich Dubielzig <rich.dubielzig@windriver.com>
> ---
> meta/recipes-multimedia/pulseaudio/pulseaudio.inc | 1 +
> .../pulseaudio/pulseaudio_2.1.bb | 2 +-
> 2 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> index 11c6355..fdf4a8a 100644
> --- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> @@ -37,6 +37,7 @@ EXTRA_OECONF = "\
> --disable-orc \
> --with-access-group=audio \
> --without-fftw \
> + --with-database=gdbm \
Please don't mix tabs and spaces for indentation.
> "
>
> PARALLEL_MAKE = ""
> diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb b/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
> index e39b69e..2f3728f 100644
> --- a/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
> +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
Isn't 3.0 already in oe-core? rebase on latest master.
> @@ -1,6 +1,6 @@
> require pulseaudio.inc
>
> -PR = "r3"
> +PR = "r4"
>
> DEPENDS += "libjson gdbm speex libxml-parser-perl-native"
>
> --
> 1.7.1
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
next prev parent reply other threads:[~2013-03-01 23:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 22:39 [PATCH V2] pulseaudio: Specify gdbm in configure Rich Dubielzig
2013-03-01 22:45 ` Martin Jansa [this message]
2013-03-01 22:58 ` [PATCH V2] pulseaudio: Specify gdbm in configure (Denzil) Rich Dubielzig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130301224538.GV3279@jama \
--to=martin.jansa@gmail.com \
--cc=Openembedded-core@lists.openembedded.org \
--cc=rich.dubielzig@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox