Re: [PATCH] openssh: don't add update-rc.d to RDEPENDS

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1943 bytes --]

On Thu, Mar 28, 2013 at 02:54:09PM +0100, Martin Jansa wrote:
> * sysvinit/systemd assumes that update-rc.d can be inhibited
> * with systemd enabled, sysvinit scripts are missing in packages
>   and update-rc.d needs to be put in BAD_RECOMMENDATIONS to prevent
>   update-rc.d trying to install them in postinst
> * update-rd.c shouldn't be in DEPENDS
> ---
>  meta/recipes-connectivity/openssh/openssh_6.1p1.bb | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-connectivity/openssh/openssh_6.1p1.bb b/meta/recipes-connectivity/openssh/openssh_6.1p1.bb
> index 32c3b2c..0cffd23 100644
> --- a/meta/recipes-connectivity/openssh/openssh_6.1p1.bb
> +++ b/meta/recipes-connectivity/openssh/openssh_6.1p1.bb
> @@ -96,8 +96,7 @@ FILES_${PN}-misc = "${bindir}/ssh* ${libexecdir}/ssh*"
>  FILES_${PN}-keygen = "${bindir}/ssh-keygen"
>  
>  RDEPENDS_${PN} += "${PN}-scp ${PN}-ssh ${PN}-sshd ${PN}-keygen"
> -DEPENDS_${PN}-sshd += "update-rc.d"
> -RDEPENDS_${PN}-sshd += "update-rc.d ${PN}-keygen"
> +RDEPENDS_${PN}-sshd += "${PN}-keygen"
>  
>  CONFFILES_${PN}-sshd = "${sysconfdir}/ssh/sshd_config"
>  CONFFILES_${PN}-ssh = "${sysconfdir}/ssh/ssh_config"

This allows to remove update-rc.d from image.
Changing error message from fatal
Configuring dbus-1.
update-rc.d: /etc/init.d/dbus-1: file does not exist
Configuring udev.
update-rc.d: /etc/init.d/systemd-udevd: file does not exist

to less fatal
Configuring dbus-1.
//var/lib/opkg/info/dbus-1.postinst: line 9: type: update-rc.d: not found
Configuring udev.
//var/lib/opkg/info/udev.postinst: line 7: type: update-rc.d: not found

I'll send separate patch to hide also stderr from "type".

Unfortunately it still hangs forever in some images when trying to start
lib/systemd/system/run-postinsts.service

After removing this service it boots fine.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]