Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Henning Heinold <heinold@inf.fu-berlin.de>
To: openembedded-core@lists.openembedded.org
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] pcmciautils: fix segmentation fault of pccardctl command
Date: Mon, 1 Apr 2013 13:17:37 +0200	[thread overview]
Message-ID: <20130401111737.GA19595@mi.fu-berlin.de> (raw)
In-Reply-To: <1364807444-20977-1-git-send-email-hmatrjp@users.sourceforge.jp>

On Mon, Apr 01, 2013 at 06:10:44PM +0900, Takeshi Hamasaki wrote:
> 
Hi,

nitpicking about spelling.

> This changes difinition of PCMCIAUTILS_VERSION to string from a multichacter constant to avoid segmentation fault of pccardctl command. 
               ^^^ 

> Signed-off-by: Takeshi Hamasaki <hmatrjp@users.sourceforge.jp>
> ---
>  meta/recipes-bsp/pcmciautils/pcmciautils.inc |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-bsp/pcmciautils/pcmciautils.inc b/meta/recipes-bsp/pcmciautils/pcmciautils.inc
> index 80271d6..0651236 100644
> --- a/meta/recipes-bsp/pcmciautils/pcmciautils.inc
> +++ b/meta/recipes-bsp/pcmciautils/pcmciautils.inc
> @@ -21,7 +21,7 @@ export udevrulesdir = "${nonarch_base_libdir}/udev/rules.d"
>  export UDEV = "1"
>  LD = "${CC}"
>  CFLAGS =+ "-I${S}/src"
> -CFLAGS =+ "-DPCMCIAUTILS_VERSION=\'${PV}\'"
> +CFLAGS =+ "-DPCMCIAUTILS_VERSION=\\"${PV}\\""
>  
>  PARALLEL_MAKE = ""
>  EXTRA_OEMAKE = "-e 'STRIP=echo' 'LIB_OBJS=-lc -lsysfs' 'LEX=flex'"
> -- 
> 1.7.10.4

Bye Henning



      reply	other threads:[~2013-04-01 11:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-01  9:10 [PATCH] pcmciautils: fix segmentation fault of pccardctl command Takeshi Hamasaki
2013-04-01 11:17 ` Henning Heinold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130401111737.GA19595@mi.fu-berlin.de \
    --to=heinold@inf.fu-berlin.de \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox