From: Denys Dmytriyenko <denis@denix.org>
To: Chase Maupin <Chase.Maupin@ti.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH][for-danny] kernel bbclass: return to original directory in do_deploy
Date: Wed, 10 Apr 2013 19:01:57 -0400 [thread overview]
Message-ID: <20130410230157.GB28466@denix.org> (raw)
In-Reply-To: <1363628359-18023-1-git-send-email-Chase.Maupin@ti.com>
Ping.
Ross, is it in your queue for your next danny merge?
--
Denys
On Mon, Mar 18, 2013 at 12:39:19PM -0500, Chase Maupin wrote:
> * During the base kernel_do_deploy function the directory is
> changed to DEPLOYDIR in order to do some cleanup and symlinking.
> However, the directory is not changed back to the original
> starting directory ${S} at the end. For append functions this
> means that the starting directory is not ${S} as expected but
> instead ${DEPLOYDIR}.
>
> For functions like the do_deploy_append in
> recipes-kernel/linux/linux-dtb.inc there is an assumption that
> you are still in the source directory and not the DEPLOYDIR.
> Without this change the .dtb files are not copied because the
> check for the existence of ${DTS_FILE} which is a relative
> path from the ${S} directory fails. This means that the .dtb
> files are not copied into the deploy directory and subsequently
> the deploy/images directory.
>
> In the log.do_deploy file you will see lines like:
>
> Warning: arch/arm/boot/dts/xxxxx.dts is not available!
>
> Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
> ---
> meta/classes/kernel.bbclass | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 88ce561..9691c25 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -529,6 +529,7 @@ kernel_do_deploy() {
> ln -sf ${KERNEL_IMAGE_BASE_NAME}.bin ${KERNEL_IMAGETYPE}
>
> cp ${COREBASE}/meta/files/deploydir_readme.txt ${DEPLOYDIR}/README_-_DO_NOT_DELETE_FILES_IN_THIS_DIRECTORY.txt
> + cd -
> }
> do_deploy[dirs] = "${DEPLOYDIR} ${B}"
>
> --
> 1.7.0.4
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
next prev parent reply other threads:[~2013-04-11 0:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-18 17:39 [PATCH][for-danny] kernel bbclass: return to original directory in do_deploy Chase Maupin
2013-04-10 23:01 ` Denys Dmytriyenko [this message]
2013-04-11 12:43 ` Maupin, Chase
2013-04-11 13:13 ` Denys Dmytriyenko
2013-04-11 13:40 ` Maupin, Chase
2013-04-11 13:44 ` Maupin, Chase
2013-04-12 21:04 ` Maupin, Chase
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130410230157.GB28466@denix.org \
--to=denis@denix.org \
--cc=Chase.Maupin@ti.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox