Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Henning Heinold <heinold@inf.fu-berlin.de>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] qemu: define fdt_t types in libfdt_env.h from qemu
Date: Sun, 14 Apr 2013 19:49:02 +0200	[thread overview]
Message-ID: <20130414174901.GA13492@mi.fu-berlin.de> (raw)
In-Reply-To: <6800403.eSx3nnyBtB@helios>

On Sun, Apr 14, 2013 at 04:25:30PM +0100, Paul Eggleton wrote:
> FWIW, the reason I asked is not because I think the fix is wrong, but to try to 
> determine - given that I couldn't reproduce the issue and the lack of 
> information about what might cause it given in the patch header - whether this 
> fix ought to be merged into the dylan branch immediately or not.
> 
> Cheers,
> Paul

Hi Paul,

okay now I see the problem, why you do not see the problem.

meta-beagleboard overrides dtc/libdtc for the latest git version.

dtc changed the following 3 headers

libenv_fdt.h
fdt.h
libfdt.h

to typedef fdt16_t, fdt32_t and fdt64_t. The typedef happens in libenv_fdt.h.
Now qemu ships its own version of libenv_fdt.h, which does not have the typedefs.

The right solution would have been letting meta-beagleboard append the patch for qemu.

On the other hand the typedefs now in qemu's version of libenv_fdt.h does not
hurt something and Richard already applied it.

Bye Henning



      reply	other threads:[~2013-04-14 18:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-13 18:35 [PATCH] qemu: define fdt_t types in libfdt_env.h from qemu Henning Heinold
2013-04-13 19:01 ` Koen Kooi
2013-04-14 11:57 ` Paul Eggleton
2013-04-14 13:50   ` Koen Kooi
2013-04-14 15:10   ` Jack Mitchell
2013-04-14 15:25     ` Paul Eggleton
2013-04-14 17:49       ` Henning Heinold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130414174901.GA13492@mi.fu-berlin.de \
    --to=heinold@inf.fu-berlin.de \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox