From: "Björn Stenberg" <bjst@enea.com>
To: Jesse Zhang <sen.zhang@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] perl-tests: convert to ptest
Date: Fri, 17 May 2013 11:31:29 +0200 [thread overview]
Message-ID: <20130517093129.GC25918@sestofb10.enea.se> (raw)
In-Reply-To: <6f982350937c07b4dd73231e4d99322cb86c6fab.1368761545.git.sen.zhang@windriver.com>
Jesse Zhang wrote:
> +--- a/t/TEST 2013-05-15 23:12:12.705104588 -0400
> ++++ b/t/TEST 2013-05-15 23:20:20.126104587 -0400
Is patching t/TEST better than simply using sed to transform the output?
I took a quick look at future versions and t/TEST is modified in both perl 5.16.3 and 5.18.0-RC4. This means the patch will have to be manually updated for each of those version updates. And the patch cannot be upstreamed.
Unless there are clear advantages with patching t/TEST that I have overlooked, I suggest using sed in run-ptest instead.
--
Björn
next prev parent reply other threads:[~2013-05-17 9:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-17 5:22 [PATCH v2 0/1] perl-tests: convert to ptest Jesse Zhang
2013-05-17 5:22 ` [PATCH 1/1] " Jesse Zhang
2013-05-17 9:31 ` Björn Stenberg [this message]
2013-05-21 2:43 ` Jesse Zhang
2013-05-21 13:50 ` Björn Stenberg
-- strict thread matches above, loose matches on Subject: below --
2013-05-14 7:57 [PATCH 0/1] " Jesse Zhang
2013-05-14 7:57 ` [PATCH 1/1] " Jesse Zhang
2013-05-14 12:58 ` Björn Stenberg
2013-05-15 7:39 ` Jesse Zhang
2013-05-15 11:01 ` Björn Stenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130517093129.GC25918@sestofb10.enea.se \
--to=bjst@enea.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=sen.zhang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox