From: "Eric Bénard" <eric@eukrea.com>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: OpenEmbedded Core Mailing List
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] base.bbclass: Add COMPATIBLE_DISTRO_FEATURES support
Date: Tue, 28 May 2013 17:21:35 +0200 [thread overview]
Message-ID: <20130528172135.187001c7@e6520eb> (raw)
In-Reply-To: <CAP9ODKqkoXrrYSyQJzRxmDfBKnQWYMUoCV8dhRvHGm2Y-sXp7g@mail.gmail.com>
Hi Otavio,
Le Tue, 28 May 2013 12:18:21 -0300,
Otavio Salvador <otavio@ossystems.com.br> a écrit :
> On Tue, May 28, 2013 at 12:12 PM, Phil Blundell <pb@pbcl.net> wrote:
> > Also also, we've managed without this functionality in oe-core for some
> > time which makes me wonder how widely useful it would actually be. If
> > it's only going to be used by a few recipes then it could go in a class,
> > or in in the recipes themselves, rather than adding parse time and
> > memory footprint to every recipe.
> >
>
> Right; let's first agree in the code so we can discuss where to put it:
>
> + need_distro_features = d.getVar('REQUIRED_DISTRO_FEATURES', True)
> + if need_distro_features:
> + need_distro_features = need_distro_features.split()
> + distro_features = (d.getVar('DISTRO_FEATURES', True) or
> "").split()
> + for f in need_distro_features:
> + if f in distro_features:
> + break
> + else:
> + raise bb.parse.SkipPackage("missing required distro
> feature %s (not in DISTRO_FEATURES)" % need_distro_features)
>
>
If I follow you want that to avoid this line in a recipe :
COMPATIBLE_MACHINE = "{@base_contains('DISTRO_FEATURES', 'x11', (mx5),
'', d)}"
maybe there is a more clean way to exclude this recipe when x11
is not present without impacting the whole build system ?
Eric
next prev parent reply other threads:[~2013-05-28 15:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 15:04 [PATCH] base.bbclass: Add COMPATIBLE_DISTRO_FEATURES support Otavio Salvador
2013-05-28 15:12 ` Phil Blundell
2013-05-28 15:18 ` Otavio Salvador
2013-05-28 15:21 ` Eric Bénard [this message]
2013-05-28 15:26 ` Otavio Salvador
2013-05-28 15:31 ` Phil Blundell
2013-05-28 16:08 ` Otavio Salvador
2013-05-28 16:28 ` Phil Blundell
2013-05-28 16:33 ` Otavio Salvador
2013-05-28 16:36 ` Phil Blundell
2013-05-28 16:39 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130528172135.187001c7@e6520eb \
--to=eric@eukrea.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=otavio@ossystems.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox