From: "Eric Bénard" <eric@eukrea.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] image.bbclass: depend on gdk-pixbuf-native
Date: Thu, 30 May 2013 09:00:55 +0200 [thread overview]
Message-ID: <20130530090055.5495d737@e6520eb> (raw)
In-Reply-To: <1369864411.14887.255.camel@ted>
Le Wed, 29 May 2013 22:53:31 +0100,
Richard Purdie <richard.purdie@linuxfoundation.org> a écrit :
> On Wed, 2013-05-29 at 23:30 +0200, Eric Bénard wrote:
> > it's using scripts from scripts/postinst-intercepts/ which contain
> > gdk-pixbuf-query-loaders so it should depend on gdk-pixbuf-native
> > else the host binary will be used and it will try to update the
> > host's cache
> >
> > [YOCTO #4572]
> >
> > Signed-off-by: Eric Bénard <eric@eukrea.com>
> > ---
> > fix the same problem in dylan
> >
> > meta/classes/image.bbclass | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> > index 04db533..6c16a1a 100644
> > --- a/meta/classes/image.bbclass
> > +++ b/meta/classes/image.bbclass
> > @@ -10,7 +10,7 @@ inherit gzipnative
> >
> > LICENSE = "MIT"
> > PACKAGES = ""
> > -DEPENDS += "${MLPREFIX}qemuwrapper-cross ${MLPREFIX}depmodwrapper-cross"
> > +DEPENDS += "${MLPREFIX}qemuwrapper-cross ${MLPREFIX}depmodwrapper-cross gdk-pixbuf-native"
> > RDEPENDS += "${IMAGE_INSTALL} ${LINGUAS_INSTALL} ${NORMAL_FEATURE_INSTALL} ${ROOTFS_BOOTSTRAP_INSTALL}"
> > RRECOMMENDS += "${NORMAL_FEATURE_INSTALL_OPTIONAL}"
>
> Ah, this has made me realise what the real problem is and that there is
> a better way to fix this. We need to add
>
> DEPENDS += "gdk-pixbuf-native"
>
> to pixbufcache.bbclass and gtk-icon-cache.bbclass then people not using
> those things don't get the dependency added.
>
I tried on gtk-icon-cache and that didn't work ... seems I missed
pixbufcache.bbclass ;-)
Eric
next prev parent reply other threads:[~2013-05-30 7:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 21:30 [PATCH] image.bbclass: depend on gdk-pixbuf-native Eric Bénard
2013-05-29 21:53 ` Richard Purdie
2013-05-30 7:00 ` Eric Bénard [this message]
2013-05-30 7:36 ` Eric Bénard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130530090055.5495d737@e6520eb \
--to=eric@eukrea.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox