Re: [PATCH] valgrind: added perl dependency

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2325 bytes --]

On Fri, Jun 07, 2013 at 07:42:52PM +0200, Martin Jansa wrote:
> On Fri, Jun 07, 2013 at 10:35:02AM -0700, eu@felipetonello.com wrote:
> > From: "Felipe F. Tonello" <eu@felipetonello.com>
> > 
> > This is necessary since the valgrind package depends on /usr/bin/perl.
> > 
> > This patch will fix this error while installing into rootfs:
> > Computing transaction...error: Can't install valgrind-3.8.1-r8@armv7a_vfp_neon: no package provides /usr/bin/perl
> 
> This doesn't look as build-time dependency and before you add it to
> RDEPENDS_${PN} use grep to find which file in valgrind package is using
> /usr/bin/perl shebang
> 
> grep -R '#/usr/bin/perl' packages-split/valgrind

ups, missed ! but you probably got the ide

> 
> and if it's just some "extra" script not always needed for valgrind,
> then move it to extra package and add perl only to
> PN-this-extra-package.
> 
> Cheers,
> 
> > 
> > Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> > ---
> >  meta/recipes-devtools/valgrind/valgrind_3.8.1.bb | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb b/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb
> > index 3520d49..ae2c5a2 100644
> > --- a/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb
> > +++ b/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb
> > @@ -8,8 +8,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=c46082167a314d785d012a244748d803 \
> >                      file://COPYING.DOCS;md5=8fdeb5abdb235a08e76835f8f3260215"
> >  
> >  X11DEPENDS = "virtual/libx11"
> > -DEPENDS = "${@base_contains('DISTRO_FEATURES', 'x11', '${X11DEPENDS}', '', d)}"
> > -PR = "r8"
> > +DEPENDS = "${@base_contains('DISTRO_FEATURES', 'x11', '${X11DEPENDS}', '', d)} perl"
> > +PR = "r9"
> >  
> >  SRC_URI = "http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \
> >  	   file://fix_issue_caused_by_ccache.patch \
> > -- 
> > 1.8.1.4
> > 
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> 
> -- 
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com



-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]