From: Laurentiu Palcu <laurentiu.palcu@intel.com>
To: Tomas Frydrych <tf+lists.yocto@r-finger.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v2 5/5] shutdown-desktop: give entire path in Exec field
Date: Thu, 4 Jul 2013 21:09:38 +0300 [thread overview]
Message-ID: <20130704180937.GA26963@lpalcu-linux> (raw)
In-Reply-To: <51D59B3D.8070303@r-finger.com>
On Thu, Jul 04, 2013 at 04:56:45PM +0100, Tomas Frydrych wrote:
> On 04/07/13 16:39, Laurentiu Palcu wrote:
> > On 07/04/2013 05:58 PM, Burton, Ross wrote:
> >> On 4 July 2013 11:58, Laurentiu Palcu <laurentiu.palcu@intel.com> wrote:
> > Even though the change you're proposing is OK, involves changing the
> > desktop file to add the @SBIN@ pattern and move the sed line to
> > do_install(). Compared to having one single line added in the
> > postinstall... I would choose the latter, unless you elaborate on what
> > do you actually mean by "nasty".
>
> Post install scripts should be avoided whenever possible and used only
> for things that cannot be done at build or install time. This clearly
> can be done at install time, so it should.
I agree. However, in this particular case I'm just being consistent with
what was already there. I would have personally moved the entire
postinstall to do_install, but the previous sed cannot be moved. So,
since we're stuck with that sed there, this one is just a harmless
addition. This is what I mean!
Laurentiu
>
> Tomas
>
> --
> http://sleepfive.com
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
next prev parent reply other threads:[~2013-07-04 18:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-04 10:56 [PATCH v2 0/5] Allow xuser to shutdown Laurentiu Palcu
2013-07-04 10:58 ` [PATCH v2 1/5] sysvinit: allow users in shutdown group to perform halt/reboot Laurentiu Palcu
2013-07-04 10:58 ` [PATCH v2 2/5] xuser-account: create separate recipe for xuser creation Laurentiu Palcu
2013-07-04 11:29 ` Burton, Ross
2013-07-04 11:58 ` Tomas Frydrych
2013-07-04 11:46 ` Martin Jansa
2013-07-04 10:58 ` [PATCH v2 3/5] connman: remove xuser creation, RDEPEND on xuser-account Laurentiu Palcu
2013-07-04 10:58 ` [PATCH v2 4/5] xserver-nodm-init: " Laurentiu Palcu
2013-07-04 10:58 ` [PATCH v2 5/5] shutdown-desktop: give entire path in Exec field Laurentiu Palcu
2013-07-04 14:58 ` Burton, Ross
2013-07-04 15:39 ` Laurentiu Palcu
2013-07-04 15:54 ` Burton, Ross
2013-07-04 15:56 ` Tomas Frydrych
2013-07-04 18:09 ` Laurentiu Palcu [this message]
2013-07-05 7:22 ` [PATCH v3 0/5] Allow xuser to shutdown (cover letter only) Laurentiu Palcu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130704180937.GA26963@lpalcu-linux \
--to=laurentiu.palcu@intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=tf+lists.yocto@r-finger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox