Re: [PATCHv2] buildhistory: Record size of installed package not compressed archive

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2268 bytes --]

On Mon, Jul 08, 2013 at 04:47:57PM +0100, Paul Eggleton wrote:
> On Saturday 06 July 2013 12:04:04 Martin Jansa wrote:
> > * usually it's more important to know how much space will each
> >   package take on target device then size of compressed package
> > * example for libewebkit0 with 4 different architectures, interesting
> >   that om_gta02 .ipk is bigger but it's smaller when installed
> > 
> >   before:
> >   MACHINE     DEFAULTTUNE       SIZE (.ipk file)
> >   om_gta04    cortexa8t-neon    15996 KiB libewebkit0
> >   qemux86_64  x86-64            16992 KiB libewebkit0
> >   spitz       xscale            16148 KiB libewebkit0
> >   om_gta02    arm920t           16260 KiB libewebkit0
> > 
> >   after:
> >   MACHINE     DEFAULTTUNE       SIZE (installed)
> >   om_gta04    cortexa8t-neon    60544 KiB libewebkit0
> >   qemux86_64  x86-64            63720 KiB libewebkit0
> >   spitz       xscale            60588 KiB libewebkit0
> >   om_gta02    arm920t           56268 KiB libewebkit0
> > 
> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > ---
> >  meta/classes/buildhistory.bbclass | 11 ++++----
> >  scripts/oe-pkgdata-util           | 59
> > ++++++++++++++++++++++++++++++++++++--- 2 files changed, 61 insertions(+),
> > 9 deletions(-)
> > 
> > diff --git a/meta/classes/buildhistory.bbclass
> > b/meta/classes/buildhistory.bbclass index 36e7fe1..1ebe68e 100644
> > --- a/meta/classes/buildhistory.bbclass
> > +++ b/meta/classes/buildhistory.bbclass
> > @@ -317,6 +317,8 @@ buildhistory_get_installed() {
> >  	# Get list of installed packages
> >  	pkgcache="$1/installed-packages.tmp"
> >  	list_installed_packages file | sort > $pkgcache
> > +	pkgcachearch="$1/installed-packages-arch.tmp"
> > +	list_installed_packages arch | sort > $pkgcachearch
> 
> If possible I would prefer to avoid having to query the installed package list 
> twice; I know that would mean changing every backend. I can look at this if 
> you're short on time.

I was thinking about adding "list_installed_packages filearch" or
something like that, but because of lack of time I could spend on this
one I decided to skip it. Feel free to improve it.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]