From: Martin Jansa <martin.jansa@gmail.com>
To: Saul Wold <sgw@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] packagegroup-core-boot: correct runtime dependencies for non-sysvinit system
Date: Fri, 2 Aug 2013 08:53:23 +0200 [thread overview]
Message-ID: <20130802065323.GT3280@jama> (raw)
In-Reply-To: <1375418740-14692-1-git-send-email-sgw@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1906 bytes --]
On Thu, Aug 01, 2013 at 09:45:40PM -0700, Saul Wold wrote:
> [YOCTO #4969]
>
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
>
> core
>
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
^^^ Something is missing and something is redundant :).
> ---
> meta/recipes-core/packagegroups/packagegroup-core-boot.bb | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-core/packagegroups/packagegroup-core-boot.bb b/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
> index d69c41d..486385a 100644
> --- a/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
> +++ b/meta/recipes-core/packagegroups/packagegroup-core-boot.bb
> @@ -30,15 +30,18 @@ VIRTUAL-RUNTIME_init_manager ?= "sysvinit"
> VIRTUAL-RUNTIME_initscripts ?= "initscripts"
> VIRTUAL-RUNTIME_keymaps ?= "keymaps"
>
> +SYSVINIT_SCRIPTS = "${@base_contains('MACHINE_FEATURES', 'rtc', 'busybox-hwclock', '', d)} \
> + modutils-initscripts \
> + init-ifupdown \
> + "
> +
> RDEPENDS_${PN} = "\
> base-files \
> base-passwd \
> busybox \
> - ${@base_contains("MACHINE_FEATURES", "rtc", "busybox-hwclock", "", d)} \
> + ${@base_contains("DISTRO_FEATURES", "sysvinit", "${SYSVINIT_SCRIPTS}", "", d)} \
> ${@base_contains("MACHINE_FEATURES", "keyboard", "${VIRTUAL-RUNTIME_keymaps}", "", d)} \
> - modutils-initscripts \
> netbase \
> - init-ifupdown \
> ${VIRTUAL-RUNTIME_login_manager} \
> ${VIRTUAL-RUNTIME_init_manager} \
> ${VIRTUAL-RUNTIME_initscripts} \
> --
> 1.8.1.4
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
prev parent reply other threads:[~2013-08-02 6:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 4:45 [PATCH] packagegroup-core-boot: correct runtime dependencies for non-sysvinit system Saul Wold
2013-08-02 6:53 ` Martin Jansa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130802065323.GT3280@jama \
--to=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=sgw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox