Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-core@lists.openembedded.org,
	Muhammad Shakeel <muhammad_shakeel@mentor.com>
Cc: openembedded-commits@lists.openembedded.org
Subject: Re: [oe-commits] Muhammad Shakeel : systemd: Remove init. d dir if systemd unit file is present and sysvinit not a distro feature
Date: Sun, 4 Aug 2013 01:23:03 +0200	[thread overview]
Message-ID: <20130803232303.GA3280@jama> (raw)
In-Reply-To: <20130731055134.2BD98504B3@opal>

[-- Attachment #1: Type: text/plain, Size: 1769 bytes --]

On Wed, Jul 31, 2013 at 05:51:34AM +0000, git@git.openembedded.org wrote:
> Module: openembedded-core.git
> Branch: master
> Commit: 823c90ad344ca2205f3055e2dcae08c6616f29b7
> URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=823c90ad344ca2205f3055e2dcae08c6616f29b7
> 
> Author: Muhammad Shakeel <muhammad_shakeel@mentor.com>
> Date:   Mon Jul 29 13:09:51 2013 +0500
> 
> systemd: Remove init.d dir if systemd unit file is present and sysvinit not a distro feature
> 
> If systemd is supported DISTRO_FEATURE and sysvinit is not and also if
> systemd_unitdir contains anything then no need to keep init.d scripts
> for sysvinit compatibility.
> 
> Signed-off-by: Muhammad Shakeel <muhammad_shakeel@mentor.com>
> Signed-off-by: Saul Wold <sgw@linux.intel.com>

There is small issue with this patch applied:

do_rootfs failing:
| Collected errors:
|  * satisfy_dependencies_for: Cannot satisfy the following dependencies
for packagegroup-core-boot:
|  *    busybox-hwclock *
|  * opkg_install_cmd: Cannot install package packagegroup-core-boot.

Systemd images with packagegroup-core-boot RDEPEND on busybox-hwclock:
meta/recipes-core/packagegroups/packagegroup-core-boot.bb:
${@base_contains("MACHINE_FEATURES", "rtc", "busybox-hwclock", "", d)} \

Which is created only when there is /etc/init.d/hwclock.sh file:
FILES_${PN}-hwclock = "${sysconfdir}/init.d/hwclock.sh"

There are at least 3 options
1) ALLOW_EMPTY_${PN}-hwclock = "1"
in busybox.inc
2) add hwclock.service to the same package
3) change packagegroup-core-boot to depend on busybox-hwclock only with
sysvinit enabled

I think the best way to resolve this is 2), any volunteer?

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

       reply	other threads:[~2013-08-03 23:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20130731055134.2BD98504B3@opal>
2013-08-03 23:23 ` Martin Jansa [this message]
2013-08-04  5:30   ` [oe-commits] Muhammad Shakeel : systemd: Remove init. d dir if systemd unit file is present and sysvinit not a distro feature Saul Wold
2013-08-04  7:12     ` Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130803232303.GA3280@jama \
    --to=martin.jansa@gmail.com \
    --cc=muhammad_shakeel@mentor.com \
    --cc=openembedded-commits@lists.openembedded.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox