From: Martin Jansa <martin.jansa@gmail.com>
To: "Peter A. Bigot" <pab@pabigot.com>
Cc: Patches and discussions about the oe-core layer
<Openembedded-core@lists.openembedded.org>
Subject: Re: recipe whitespace style questions
Date: Wed, 14 Aug 2013 16:13:39 +0200 [thread overview]
Message-ID: <20130814141339.GY17945@jama> (raw)
In-Reply-To: <520B8B6C.40408@pabigot.com>
[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]
On Wed, Aug 14, 2013 at 08:51:40AM -0500, Peter A. Bigot wrote:
>
> SRC_URI = "file://skeleton \
> file://skeleton_test.c \
> file://COPYRIGHT \
> "
>
> which I'll call "none", and;
>
> SRC_URI = "file://skeleton \
> file://skeleton_test.c \
> file://COPYRIGHT"
>
> which I'll call "joined".
>
> Again, for consistency's sake it would be nice to have a
> recommendation. I personally prefer "none", which matches the closing
> bracket style for functions.
>
> Next: I've also seen:
>
> SRC_URI = " \
> file://skeleton \
> file://skeleton_test.c \
> file://COPYRIGHT \
> "
I prefer this one (especially for longer variables or entries) or "none",
because with "none" it's easier to see where multiline variable ends.
Worst is IMHO "joined" because when appending one more line you have to
edit 2 lines to move '"' so the diff for review is longer and harder to
read than just one added line.
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
next prev parent reply other threads:[~2013-08-14 14:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 13:51 recipe whitespace style questions Peter A. Bigot
2013-08-14 14:13 ` Martin Jansa [this message]
2013-08-14 14:15 ` Chris Larson
[not found] ` <20130814143157.GB3894@windriver.com>
2013-08-19 22:57 ` Peter A. Bigot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130814141339.GY17945@jama \
--to=martin.jansa@gmail.com \
--cc=Openembedded-core@lists.openembedded.org \
--cc=pab@pabigot.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox